On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> src/service-dbus/test/testService.py, line 114
>
<
http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443li...
>
> sysd_state = ret == 0
Robin Hack wrote:
It's more harder to read without parentheses.
I'm ok with parentheses but not with the ternary operator.
- Radek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------
On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/
-----------------------------------------------------------
(Updated Sept. 2, 2013, 1:16 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Service tests: Upstream test for service profider from QA.
Diffs
-----
src/service-dbus/test/failing.service PRE-CREATION
src/service-dbus/test/testService.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/805/diff/
Testing
-------
Thanks,
Robin Hack