This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/805/

On September 2nd, 2013, 1:58 p.m. CEST, Radek Novacek wrote:

src/service-dbus/test/testService.py (Diff revision 1)
114
            sysd_state = True if (ret == 0) else False
sysd_state = ret == 0

On September 3rd, 2013, 9:08 a.m. CEST, Robin Hack wrote:

It's more harder to read without parentheses.
I'm ok with parentheses but not with the ternary operator.

- Radek


On September 2nd, 2013, 1:16 p.m. CEST, Robin Hack wrote:

Review request for OpenLMI Developers.
By Robin Hack.

Updated Sept. 2, 2013, 1:16 p.m.

Repository: openlmi-providers

Description

Service tests: Upstream test for service profider from QA.

Diffs

  • src/service-dbus/test/failing.service (PRE-CREATION)
  • src/service-dbus/test/testService.py (PRE-CREATION)

View Diff