-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/#review2576
-----------------------------------------------------------
src/software-dbus/sw-utils.h
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1411>
values_p should have const qualifiers since it shall not be changed.
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1410>
splitted -> split
:)
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1412>
Usually caller does know how many values are there, therefor I'd add also
"int values_n" parameter. If negative (caller does not know), this line
would be used as a fallback to compute it.
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1413>
IMHO repo_id needs to be freed with g_free().
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1414>
No need to dup it.
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1415>
Free repo_id.
Even better, use pk_repo_detail_get_id () - no free needed.
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1667/#comment1416>
Use pk_repo_detail_get_id ()
- Michal Minar
On May 5, 2014, 3:27 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/
-----------------------------------------------------------
(Updated May 5, 2014, 3:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c
9332f62e392103e39a700cedcfaadf72df8e5f53
src/software-dbus/LMI_SoftwareIdentityProvider.c
7e03badf0113ebc981a24d20ccac60131dfb8d74
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c
fec2794131a6194510364e45969995729e80108c
src/software-dbus/sw-utils.h 16e6ca11e4714ab337c7e554f7c8ced5b06bd37b
src/software-dbus/sw-utils.c 76ca58bd0129c3d12695d22da77fb3613c8685b1
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1667/diff/
Testing
-------
Thanks,
Peter Schiffer