src/software-dbus/sw-utils.h
(Diff revision 1)
|
void create_instance_from_pkgkit_data(PkPackage *pk_pkg, PkDetails *pk_det, |
|
|
193 |
void get_pk_det_from_array(char **values_p, GPtrArray **garray, PkTask *task_p); |
values_p should have const qualifiers since it shall not be changed.
Usually caller does know how many values are there, therefor I'd add also
"int values_n" parameter. If negative (caller does not know), this line would be used as a fallback to compute it.
IMHO repo_id needs to be freed with g_free().
Free repo_id.
Even better, use pk_repo_detail_get_id () - no free needed.
src/software-dbus/sw-utils.c
(Diff revision 1)
|
|
|
829 |
g_object_get(al, "repo-id", &repo_id_a, NULL); |
|
|
830 |
g_object_get(bl, "repo-id", &repo_id_b, NULL); |
Use pk_repo_detail_get_id ()
- Michal Minar
On May 5th, 2014, 3:27 p.m. UTC, Peter Schiffer wrote:
Review request for OpenLMI Developers.
By Peter Schiffer.
Updated May 5, 2014, 3:27 p.m.
Repository:
openlmi-providers
Description
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
|
Diffs
- src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c (9332f62e392103e39a700cedcfaadf72df8e5f53)
- src/software-dbus/LMI_SoftwareIdentityProvider.c (7e03badf0113ebc981a24d20ccac60131dfb8d74)
- src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (fec2794131a6194510364e45969995729e80108c)
- src/software-dbus/sw-utils.h (16e6ca11e4714ab337c7e554f7c8ced5b06bd37b)
- src/software-dbus/sw-utils.c (76ca58bd0129c3d12695d22da77fb3613c8685b1)
View Diff
|