On Oct. 30, 2013, 3:44 p.m., Radek Novacek wrote:
> src/software/test/testSoftware.py, line 98
>
<
http://reviewboard-openlmi.rhcloud.com/r/1147/diff/1/?file=6187#file6187l...
>
> What is the purpose of this function? Remove epoch from NVR? If so then note
that epoch could be arbitrary number, this works only for epoch <0..9>.
Michal Minar wrote:
Yeah, some kind of description "why?" would be helpful. I would use regular
expression:
string = re.sub(r'-\d+:', '-', string)
Actually not used anywhere in the code, so I'm removing it completely.
On Oct. 30, 2013, 3:44 p.m., Radek Novacek wrote:
> src/software/test/testSoftware.py, line 255
>
<
http://reviewboard-openlmi.rhcloud.com/r/1147/diff/1/?file=6187#file6187l...
>
> use "assertListEqual", it produces better output when the test fails
Michal Minar wrote:
Unfortunately this is available since python 2.7.
I'm afraid there are more pieces of tests code that won't work on 2.6
Shall we strictly support python 2.6 and more, or is it ok to run with 2.7 and eventually
rewrite tests for older python versions when it's needed?
On Oct. 30, 2013, 3:44 p.m., Radek Novacek wrote:
> src/software/test/testSoftware.py, line 312
>
<
http://reviewboard-openlmi.rhcloud.com/r/1147/diff/1/?file=6187#file6187l...
>
> You can use
>
> .InstalledSoftware.InstanceID
>
> instead of
>
> .path["InstalledSoftware"]["InstanceID"]
Michal Minar wrote:
From what I know:
.InstalledSoftware["InstanceID"]
Because InstalledSoftware is an instance of pywbem.CIMInstanceName, which doesn't
allow for smart attribute access.
This shortcut somewhere works for me, but in this specific place is doesn't.
TypeError: 'LMIInstanceName' object has no attribute '__getitem__'
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/#review1566
-----------------------------------------------------------
On Oct. 30, 2013, 3:03 p.m., Jan Grec wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
(Updated Oct. 30, 2013, 3:03 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any
comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec