-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1570/#review2445
-----------------------------------------------------------
Ship it!
Apart from the minor issue, looks good. Ship it!
src/software-dbus/sw-utils.c
<
http://reviewboard-openlmi.rhcloud.com/r/1570/#comment1305>
Move the initialization to the first for loop.
- Michal Minar
On April 4, 2014, 12:15 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1570/
-----------------------------------------------------------
(Updated April 4, 2014, 12:15 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: implemented MemberOfSoftwareCollectionProvider
Diffs
-----
src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c
dcae7910c2bfb0f628f802ffda010a7ae52873c2
src/software-dbus/LMI_Software.h 6e434f95c43f27d9e378d891eccf318ee30c3ee2
src/software-dbus/LMI_SoftwareIdentityProvider.c
09fbd93d2775145dcc5c57d160360d90371206b8
src/software-dbus/sw-utils.h 0735259281281b8e49a5748a69aaccd1e09fec14
src/software-dbus/sw-utils.c 3cfa1759773f141a4d02ba25bbf1846fa603879a
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1570/diff/
Testing
-------
Thanks,
Peter Schiffer