Review Request 825: fix memory corruption [1/1] Account: Fix memory corruption
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/825/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Fix memory corruption
There was false assumption that lu_end doesn't free error messages.
The code is restructured to copy error message to temporary string
holder, which is freed after and error message is correctly returned,
all in one place.
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountProvider.c c58b001c52fb7e84425e403d02779efb172a5122
src/account/LMI_GroupProvider.c d3263f47fb8366703e334732dedc86c11b446974
src/account/LMI_IdentityProvider.c e008746e89ba7eab4e9a24c5647c048a88a51d8e
src/account/LMI_MemberOfGroupProvider.c b06cd437c6e80d759565d6746b9b402133793170
Diff: http://reviewboard-openlmi.rhcloud.com/r/825/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 8 months
Review Request 814: exit [1/1] Account: Use return CIM_RC_ERR_FAILED instead of exit(1)
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/814/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Use return CIM_RC_ERR_FAILED instead of exit(1)
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountCapabilitiesProvider.c 1636ab7ad7b894bd9800f4fd8a20d22e9533fab2
src/account/LMI_AccountOnSystemProvider.c ab84097648ec2cbd883276f8e981d7c596a9ca5e
src/account/LMI_AccountProvider.c f1a2546b3fbcacfebd18d4dcdac4283ff93f49c2
src/account/LMI_AssignedAccountIdentityProvider.c 72f5d1e1c9b34d35fd49b2ab9062ee5e8ae53424
src/account/LMI_AssignedGroupIdentityProvider.c c474bf92b3c54f53344f4cb0e62a40912022a4cc
src/account/LMI_GroupProvider.c 5356eacf48a3b7d31230fc1f72eabf98dc494269
src/account/LMI_IdentityProvider.c 81cd68eb912156be70f1857144265c6ae5b3d691
src/account/LMI_MemberOfGroupProvider.c 60259b85dbefeb0a57c36dadee666579d2d9994e
src/account/LMI_OwningGroupProvider.c 317b7b4a4ec002acda6aa2b6a933a76ca41369a9
src/account/LMI_ServiceAffectsIdentityProvider.c 6155010518468dfdaecf38b37567c3206fa7e7e6
Diff: http://reviewboard-openlmi.rhcloud.com/r/814/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 8 months