Review Request 583: [2/2] Add LUKS version 1.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff: http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek
10 years, 7 months
Review Request 792: Hardware: Get rid of different error return codes.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/792/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Get rid of different error return codes.
Different error return code for every failure in function is pretty useless, so,
get rid of them. Now, if function exits successfully, 0 is returned. In case of
any problem, function returns -1 and prints warning log message.
Diffs
-----
src/hardware/LMI_ProcessorProvider.c 8b5ba1170766ce99020bde3e883d9bf3539f613d
src/hardware/dmidecode.c 84ce0c1b09c0654ed95c3993e82c7808260bb7f0
src/hardware/lscpu.c be00f87680d6b09965d7b75ac200847d94789e19
src/hardware/procfs.c 3c01cd420af99d1d4aa527aeb837fbbb4e179e8d
src/hardware/sysfs.c 084a11d8589134b1a4b70a70f8f5824e5c502da2
src/hardware/utils.c f23be27def1506d7712020d54482838ee45617d5
Diff: http://reviewboard-openlmi.rhcloud.com/r/792/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 7 months