Review Request 792: Hardware: Get rid of different error return codes.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/792/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Get rid of different error return codes.
Different error return code for every failure in function is pretty useless, so,
get rid of them. Now, if function exits successfully, 0 is returned. In case of
any problem, function returns -1 and prints warning log message.
Diffs
-----
src/hardware/LMI_ProcessorProvider.c 8b5ba1170766ce99020bde3e883d9bf3539f613d
src/hardware/dmidecode.c 84ce0c1b09c0654ed95c3993e82c7808260bb7f0
src/hardware/lscpu.c be00f87680d6b09965d7b75ac200847d94789e19
src/hardware/procfs.c 3c01cd420af99d1d4aa527aeb837fbbb4e179e8d
src/hardware/sysfs.c 084a11d8589134b1a4b70a70f8f5824e5c502da2
src/hardware/utils.c f23be27def1506d7712020d54482838ee45617d5
Diff: http://reviewboard-openlmi.rhcloud.com/r/792/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 7 months
Re: Review Request 791: Delete user [2/2] Account: New delete method
by Stephen Gallagher
> On Aug. 30, 2013, 12:08 p.m., Radek Novacek wrote:
> > mof/60_LMI_Account.mof, line 52
> > <http://reviewboard-openlmi.rhcloud.com/r/791/diff/2/?file=4412#file4412li...>
> >
> > procest -> process
Text changed. I think it wasn't necessary.
> On Aug. 30, 2013, 12:08 p.m., Radek Novacek wrote:
> > mof/60_LMI_Account.mof, line 75
> > <http://reviewboard-openlmi.rhcloud.com/r/791/diff/2/?file=4412#file4412li...>
> >
> > Use upppercase F in force to be consistent with other arguments
Ok. Done.
- Roman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/791/#review1034
-----------------------------------------------------------
On Aug. 30, 2013, 3:36 p.m., Roman Rakus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/791/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 3:36 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Account: New delete method
>
> This method should be used insted of intrinsic DeleteInstace.
>
> Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
>
>
> Diffs
> -----
>
> mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251
> src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Rakus
>
>
10 years, 8 months
Re: Review Request 791: Delete user [2/2] Account: New delete method
by Stephen Gallagher
> On Aug. 30, 2013, 12:08 p.m., Radek Novacek wrote:
> > src/account/LMI_AccountProvider.c, line 480
> > <http://reviewboard-openlmi.rhcloud.com/r/791/diff/2/?file=4413#file4413li...>
> >
> > Don't use exit(1) in the provider, IMHO it might cause the caller to hang. Rather return some error message.
Created ticket for it: https://fedorahosted.org/openlmi/ticket/146 Will do fix for all of this issues.
- Roman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/791/#review1034
-----------------------------------------------------------
On Aug. 30, 2013, 3:27 p.m., Roman Rakus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/791/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2013, 3:27 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Account: New delete method
>
> This method should be used insted of intrinsic DeleteInstace.
>
> Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
>
>
> Diffs
> -----
>
> mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251
> src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Rakus
>
>
10 years, 8 months
Review Request 786: storage: Bump release.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/786/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
storage: Bump release.
Diffs
-----
CHANGES d5b4835b003b7930018727df35be4f8e5c2bfa9c
doc/admin/conf.py b8c41e8169f6ffa3535355dc6639fff28699d564
doc/devel/conf.py 4b449dd8d6c0bae00c44abd581526532cfba4305
mof/70_LMI_Storage-Profiles.mof d02eb7361337bbe3e9cd3f584ddd958dca01e1da
openlmi-storage.spec 5df500498956b95ee2e09d3856bdce904a26a8d4
setup.py 13282bdd032959200c88946769c8bf2e4538ceb5
Diff: http://reviewboard-openlmi.rhcloud.com/r/786/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 8 months
Review Request 785: Added Name property to LMI_VGStoragePool.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/785/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Added Name property to LMI_VGStoragePool.
Having Name property both in LMI_VGStoragePool and CIM_StoragePool
simplifies client development.
Diffs
-----
mof/LMI_Storage-BlockStorage.mof 0d39cd04b29d27d181d599305fb050c379842b16
src/lmi/storage/LMI_VGStoragePool.py 0a9f61f026f23745c1d007642be82949baf90278
Diff: http://reviewboard-openlmi.rhcloud.com/r/785/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 8 months
Review Request 784: Added InstanceID to CIM_StorageExtent.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/784/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Added InstanceID to CIM_StorageExtent.
Now both LMI_VGStoragePool and all CIM_StorageExtents have InstanceID
property to uniquely identify them. It will simplify the client scripts,
which now don't need to distinguish between CIM_StorageExtent.DeviceID and
LMI_VGStoragePool.InstanceID.
Still, CIM_StorageExtent.DeviceID is the primary key for StorageExtents.
Diffs
-----
mof/LMI_Storage-Base.mof c82e535531e25eb6e49991aa985d722b07225b38
mof/LMI_Storage-Partitions.mof 3a2dd0743cab26a82dbc5e5d86351a2d2d88de4b
src/lmi/storage/ExtentProvider.py 736c11a5519c74a21a65c06c0ab22f7ee80783b6
Diff: http://reviewboard-openlmi.rhcloud.com/r/784/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 8 months