-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/691/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, all the wrapper classes (LMINamespace, LMIClass, LMIInstance{Name}, LMIMethod) have now property "connection", which returns the former LMIConnection object retrieved by connect().
Diffs
-----
cli/lmi/shell/LMIBaseObject.py 08d05513892c68388d76730652df1d07ced626f9
cli/lmi/shell/LMIClass.py 5e8db27847d9ddefb7883946b8ae8fe65faf5eee
cli/lmi/shell/LMIConnection.py 786fdd578b06873fe51528acaca575cde00133c7
cli/lmi/shell/LMIInstance.py af83f647b0037a259d0e5fdfefbd0176ead41dba
cli/lmi/shell/LMIInstanceName.py 20440cb20af0671a927de547d3537f5206cd7a50
cli/lmi/shell/LMIMethod.py 3a05740aab526f9cf3f35b2ae6d33e0555c5572f
cli/lmi/shell/LMINamespace.py 72a5f4d88d370768fe58c9796cfc1c45b14ad036
cli/lmi/shell/LMIUtil.py 370c073a22c2461428c066d019326d9941235679
Diff: http://reviewboard-openlmi.rhcloud.com/r/691/diff/
Testing
-------
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/677/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch finishes so-called synchronous method calls in terms of proper return value, parameters and error string set.
Diffs
-----
cli/lmi/shell/LMIMethod.py 6b604625998aa2dc88b9ebed2c9e65299b2b91b2
Diff: http://reviewboard-openlmi.rhcloud.com/r/677/diff/
Testing
-------
Tested with openlmi-storage provider.
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/549/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
By this patch, we introduce a feature, which enables LMIShell to perform synchronous method calls. In other words, when there is a method call executed, which returns a CIM_ConcretJob object (derived from), LMIShell is able to either subscribe an indication and then wait for the job to finish and return job output parameters. If the shell is not able to use indications (can not start tcp server), then it uses "blind" polling as the waiting method. Indication method of waiting also checks the JobState value of the object to prevent the shell from infinite waiting.
To invoke a "synchro" method, see following (example with filesystem):
> ... some stuff to get necessary objects ...
> conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
^^^^
The prefix "Sync" is also added to interactive interface (tab-completion).
Question 1)
As the patch of a version 1, there is only unsecure http used for indication delivery. The question is: what kind of certificate to use, do we generate some for the shell at install time, or use some existing? Please, tell me your opinion.
Question 2)
Can we setup Pegasus to permit other users to create objects in the namespace PG_InterOp? In the example below, there is root account used, other users for me with default Pegasus setup can not create indication handler and subscription objects. Now, the shell will fail to get necessary static filter instance (used for the subscription) and will fail to call "synchro" method.
Diffs
-----
cli-tools/lmi/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
cli-tools/lmi/lmi_client_shell.py 9a6788cc17582f7c4419df909cd4322d9e6b23f9
cli-tools/lmi/lmi_listener.py 6670b204a84485b6e1f8bef5dfa2893098f0a9da
cli-tools/lmishell a12233eedc159a6f6c570ca31dfff20ac6d17161
Diff: http://reviewboard-openlmi.rhcloud.com/r/549/diff/
Testing
-------
Tested with storage provider.
> c = connect("hostname", "root", "root")
> sda = c.root.cimv2.LMI_StorageExtent.first_instance({"ElementName" : "sda"})
> basedon = sda.first_reference(ResultClass = "LMI_PartitionBasedOn")
> sda1 = basedon.Dependent.to_instance()
> conf_service = c.root.cimv2.LMI_FileSystemConfigurationService.first_instance()
> (ret, out, err) = conf_service.SyncLMI_CreateFileSystem(FileSystemType = 11, InExtents = [sda1])
> print "%s\n%s\n%s" % (ret, out, err)
4096
NocaseDict({'out': _LmiInstance(classname='CIM_ManagedElement', ...)})
Note: see return value and output parameters (ret == 4096, out['out'] == _LmiInstance(...)) <- this will be changed once we have Pegasus fixed. Now synchro method does not modify return value of the method, therefore you can find 4096 in the result. Once we have proper values in output parameters (Job.JobOutParameters), return code and return parameters will be modified respectively.
Thanks,
Peter Hatina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/764/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Include process name and PID in the message
Let's be consistent with traditional syslog message format.
Diffs
-----
src/journald/instutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/764/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/759/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Map the PRIORITY field to CIM_RecordForLog.PerceivedSeverity
Records in journal may contain syslog-style priority value so let's use
them. Unfortunately mapping the particular values between syslog and CIM
classes is not linear, manual mapping is needed.
The LOG_ERR may also map to PerceivedSeverity = Major but it's kept on
Minor for the moment.
If no such information is provided by the Journal, the CIM property is
left unset for the particular record.
See e.g. http://schemas.dmtf.org/wbem/cim-html/2.34.0/CIM_RecordForLog.html
for valuemap description.
Diffs
-----
src/journald/instutil.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/759/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/690/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Basic provider implementation
This is a fully functional basic implementation of the provider.
Maximum number of enumerated instances is limited, see the code.
Diffs
-----
CMakeLists.txt f150e4c77b3cf0475ff906b019da8bdcfab79676
mof/60_LMI_Journald.mof PRE-CREATION
src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743
src/journald/CMakeLists.txt PRE-CREATION
src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION
src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION
src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION
src/journald/README PRE-CREATION
src/journald/TODO PRE-CREATION
src/journald/cmpiLMI_Journald-cimprovagt PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/journal.h PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/690/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Use lmi logging infrastructure for error messages
--
This is an addendum to review #731
Diffs
-----
src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION
src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION
src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION
src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/journal.h PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/731/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Add indications
Also contains simple test suite to test indications.
Still contains some TODOs as there's a copy-pasted code that could live in a shared place.
Diffs
-----
mof/60_LMI_Journald.mof PRE-CREATION
src/journald/CMakeLists.txt PRE-CREATION
src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/test/TestIndications.py PRE-CREATION
src/journald/test/common.py PRE-CREATION
src/journald/test/localtest.sh PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/731/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/cimom_entry.py a7c765244cd4fee2308a42c9147c15f1ff07a98f
Diff: http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek