Review Request 1146: indmanager: Use proper mutex error checking
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1146/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
indmanager: Use proper mutex error checking
Things are bit harsh in the indication manager when it comes to cancellation.
At certain situation we force-cancel the polling thread, having no chance
for cleanup. The mutex we use to protect memory shared between threads may
be left in undefined state.
The pthread_mutex_unlock() call in im_stop_ind() may be called on already
unlocked mutex which, in default setup, causes a segfault. Setting a mutex
attribute PTHREAD_MUTEX_ERRORCHECK will prevent this, returning proper error.
Diffs
-----
src/indmanager/ind_manager.c 805806f3db53166df7fab83bcc99f53c31705313
Diff: http://reviewboard-openlmi.rhcloud.com/r/1146/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 6 months