Review Request 1167: providers-tests [1/5] providers: enhanced base test class
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1167/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
providers: enhanced base test class
Added lots of convenience methods. Allowed to use lmi.shell abstractions
if available. openlmi-tools do not need to be installed to use the base
class.
CIMInstanceName and LMIInstanceName are treated the same way
(functions operate upon CIMInstanceName objects and lmi wrappers are
converted to them before the call is done).
Diffs
-----
src/python/lmi/test/base.py eb009144c45f38343ad032361089e13863daa2f2
Diff: http://reviewboard-openlmi.rhcloud.com/r/1167/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 5 months
Review Request 1171: providers-tests [5/5] software: temporarily disabled dangerous tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1171/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: temporarily disabled dangerous tests
Dangerous tests changing yum package database are not reliable because
they operate on dynamically changing repositories. This patch
temporarily disables them until custom testing repositories are created
for the purpose of software tests.
Diffs
-----
src/software/test/base.py 35e437a65713cfdc5798f928a1e479eec14f3c9a
src/software/test/test_installed_software_identity.py 31bbd1cdb373f621d9ce53f12b7406cc08ef6f40
Diff: http://reviewboard-openlmi.rhcloud.com/r/1171/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 5 months
Review Request 1166: providers: Prevent libglib2 from unloading
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1166/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Prevent libglib2 from unloading
On shutdown, Pegasus CIMOM unloads (dlclose()) the provider first and then
destroys its worker threads. Since glib2 uses pthread_key_create()
internally, thread local storage destructors are called to free glib2's
data. As glib2 is already unloaded, the provider crashes.
This patch manually opens glib2 so it is not unloaded on dlclose() of
the provider shared library and thus the thread shutdown callbacks
do not crash.
Diffs
-----
src/CMakeLists.txt e2317ed535c90c8b73e5ac3d63b9d744d7c3d6e8
src/openlmi.c 1dc1b62e30782b63ef9ddab746625a28109bfb4f
Diff: http://reviewboard-openlmi.rhcloud.com/r/1166/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 5 months
Review Request 1165: storage: Use get_system_name() to get name from CIMOM instead of simple domain name
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1165/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Use get_system_name() to get name from CIMOM instead of simple domain name
ComputerSystem.Name is now opaque to the provider and the CIMOM can use any
CoputerSystem implementation.
Diffs
-----
src/lmi/storage/CapabilitiesProvider.py edd7b888526d6894957d2c01f9894ce5a25acfdd
src/lmi/storage/ExtentProvider.py dcff358eaab7ed7075ad358bf1253d4fc31e33d3
src/lmi/storage/FormatProvider.py a3323b722ac01f7bc3eb7ae9e9981ff2f8c808b8
src/lmi/storage/LMI_AttachedFileSystem.py 86185e681dc7fd85cca9c48707f02495e783b418
src/lmi/storage/LMI_BlockStorageStatisticalData.py ab586d2d13caf0ca2fa91e175b1c16dd4854bbb5
src/lmi/storage/LMI_HostedFileSystem.py e0487d7ab744289c2874a4ba601abc08bd68d90e
src/lmi/storage/LMI_HostedMount.py 0e4803d5d3b1ba0dd1fecc8730c6d5e787489613
src/lmi/storage/LMI_HostedStorageService.py c1778e5e74a547c36680a01065d7a95a7507e70b
src/lmi/storage/LMI_MountPoint.py 470028e358b713b96eeaff6a9fd91689314776f0
src/lmi/storage/LMI_SystemStorageDevice.py b9f5ba030100c25a515153cdbb8f4899ba1054db
src/lmi/storage/ServiceProvider.py 31af03e6db2004a4d5a856faf9d9bfe2186b3905
src/lmi/storage/cimom_entry.py 6a3c35ae661f39c603dbbc8ed21ac0fe09d13187
Diff: http://reviewboard-openlmi.rhcloud.com/r/1165/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 5 months
Review Request 1160: providers [3/3] software: use shared ComputerSystem module
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1160/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: use shared ComputerSystem module
Diffs
-----
src/software/lmi/software/LMI_AffectedSoftwareJobElement.py c0c5ceb3fe8b5421575560f931887bc334a6761f
src/software/lmi/software/LMI_AssociatedSoftwareInstallationServiceCapabilities.py 3cda2593c8cc47aade2319dff1e95de3840cb0dc
src/software/lmi/software/LMI_HostedSoftwareCollection.py 9f87e1c74a01b6ea28a271bbdb6fceb4ec2a6357
src/software/lmi/software/LMI_HostedSoftwareIdentityResource.py 8c27850cb394b1e09c7a0525f0da8ba7d5621a5d
src/software/lmi/software/LMI_HostedSoftwareInstallationService.py a581c76f4c07529ca9e5d57b19b4e2128a26579b
src/software/lmi/software/LMI_InstalledSoftwareIdentity.py 846317104c08f9b85c7eee2e1477842ca03d0458
src/software/lmi/software/LMI_OwningSoftwareJobElement.py 23b51a25f9457ee7717aba3c562d6032ea51d750
src/software/lmi/software/LMI_ResourceForSoftwareIdentity.py 6a9d7af97882004e22c37c422a51e379ebe279dc
src/software/lmi/software/LMI_SoftwareIdentityFileCheck.py aa42e0d01c8bdd6ec0390244facf8313f76e8edb
src/software/lmi/software/LMI_SoftwareIdentityResource.py 46a334647732161ffcca40e66a52032186b43a07
src/software/lmi/software/LMI_SoftwareInstallationService.py 3e93ba4e196a44e70595874250dd151fe37cb7f4
src/software/lmi/software/LMI_SoftwareInstallationServiceAffectsElement.py c46e6bd6b5d637fd07131f8550e452d80b8b3b8e
src/software/lmi/software/core/AffectedSoftwareJobElement.py 9a0e3702e6fbe55a57c4f2b4ccbd35c89a229498
src/software/lmi/software/core/ComputerSystem.py 30e03cf16003e9079327f4dfbae81fad858f66ab
src/software/lmi/software/core/Error.py b199fdd163f951a2ef2e1d1f26a4d89079dae953
src/software/lmi/software/core/IdentityResource.py 884e09b3b36d1fcb9e0dc9b135575e8570480029
src/software/lmi/software/core/InstallationService.py e7e43c87e7230c1dabc6a60963686a2738a29488
src/software/lmi/software/core/InstallationServiceAffectsElement.py fc1d3174a9abf3567ba208b6c3c42dc0b68e0903
src/software/lmi/software/util/__init__.py e5bcc119b870b5754cf838841cb6df099b9f7556
Diff: http://reviewboard-openlmi.rhcloud.com/r/1160/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 5 months
Review Request 1159: providers [2/3] python: solve ComputerSystem issues
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1159/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
python: solve ComputerSystem issues
Added ComputerSystem module to lmi.providers with convenience functions
allowing to obtain instance from CIMOM and check for its correctness
when inspecting client's input.
Diffs
-----
src/python/lmi/base/BaseConfiguration.py 8333cca4bc91ad223a69de4a7b53d701a46cecc9
src/python/lmi/providers/ComputerSystem.py PRE-CREATION
src/python/lmi/providers/__init__.py baebcdb2c112811bd07d57fe74b073b3291bc35b
Diff: http://reviewboard-openlmi.rhcloud.com/r/1159/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 5 months