On July 29, 2013, 10:37 a.m., Roman Rakus wrote:
src/setting.c, lines 75-76 http://reviewboard-openlmi.rhcloud.com/r/589/diff/1/?file=3433#file3433line75
I don't like these magic numbers.
Radek Novacek wrote: These are default values taken from NetworkManager, I'll add comment to specify where they come from.
So the best will be if NetworkManager will export these values.
- Roman
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/589/#review800 -----------------------------------------------------------
On July 29, 2013, 10:55 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/589/
(Updated July 29, 2013, 10:55 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Read brigde slave settings from NM
Diffs
src/globals.h 091181c9d61973a9a34b9d04d7d13f368a2f566b src/setting.h 09f5a258b5c0dd86fe091152f45096dc18bea450 src/setting.c 79548584fa25bc0dc1234c194ea83aafe3caf6b1 src/setting_nm.c 9ea12230fe2645be5a10091548c82aad77362112 src/setting_private.h c54980d47a9e58cc0ce87ed336beccb3018da2bd
Diff: http://reviewboard-openlmi.rhcloud.com/r/589/diff/
Testing
Thanks,
Radek Novacek