This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/589/ |
On July 29th, 2013, 10:37 a.m. UTC, Roman Rakus wrote:
src/setting.c (Diff revision 1) Setting *setting_new(SettingType setting_type)75 setting->typespec.bridge_slave.priority = 32;76 setting->typespec.bridge_slave.path_cost = 100;I don't like these magic numbers.On July 29th, 2013, 10:45 a.m. UTC, Radek Novacek wrote:
These are default values taken from NetworkManager, I'll add comment to specify where they come from.
So the best will be if NetworkManager will export these values.
- Roman
On July 29th, 2013, 10:55 a.m. UTC, Radek Novacek wrote:
Review request for OpenLMI Developers.
By Radek Novacek.
Updated July 29, 2013, 10:55 a.m.
Repository:
openlmi-networking
Description
Diffs
|