-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
This is my first patch, and I had limited resources for testing.
Consider this a 'working in progress'
Feel free to submit feedback. One thing I still would like to do is:
cobbler report --what=system --list-all-fields
Which would provide a list of all available fields to anyone who would like use customize the report with the --fields options.
AS
Anderson Silva wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
This is my first patch, and I had limited resources for testing.
Consider this a 'working in progress'
Feel free to submit feedback. One thing I still would like to do is:
cobbler report --what=system --list-all-fields
Which would provide a list of all available fields to anyone who would like use customize the report with the --fields options.
AS -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFIsu4eECmX3C4JWKgRAvXHAJ9fjchsN4HZGP1nRxRSc61D4MpvAwCgmaEU DxxxfgJWaV6mDwl5qQOqwHg= =kKk1 -----END PGP SIGNATURE-----
cobbler mailing list cobbler@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler
Thanks! I'm going to hold this until 1.2 is released (should be Thursday/Friday) and then I'll merge and (if needed), we can work on what else it might need.
Having a cleaner way to generate textual reports that are readable in columns will be very good to have.
--Michael
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I forgot to add the cli_report.py to the patch yesterday, here is an updated version. My bad.
AS
Anderson Silva wrote:
This is my first patch, and I had limited resources for testing.
Consider this a 'working in progress'
Feel free to submit feedback. One thing I still would like to do is:
cobbler report --what=system --list-all-fields
Which would provide a list of all available fields to anyone who would like use customize the report with the --fields options.
AS
- ------------------------------------------------------------------------
_______________________________________________ cobbler mailing list cobbler@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler
Anderson Silva wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I forgot to add the cli_report.py to the patch yesterday, here is an updated version. My bad.
AS
Anderson Silva wrote:
This is my first patch, and I had limited resources for testing.
Consider this a 'working in progress'
Feel free to submit feedback. One thing I still would like to do is:
cobbler report --what=system --list-all-fields
Which would provide a list of all available fields to anyone who would like use customize the report with the --fields options.
AS
cobbler mailing list cobbler@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFItAFYECmX3C4JWKgRAjnRAKDDT5YLKNPhF7AJSVEO7NporxpsjwCgvY0M vNb/5Jmoj5MSMQc6YO/zYuc= =Hd8N -----END PGP SIGNATURE-----
cobbler mailing list cobbler@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler
Ok, as I'm now cleared up with having 1.2 released, it's time to look into applying this -- Currently this doesn't apply to devel head, as I'm getting a few rejections (cli_report.py, cli_misc.py). I tried applying manually by removing ReportFunction from cli_misc manually and copying your code into api.py, but upon doing that, simple commands like "cobbler report --what=distros" just printed "None", and I did not dig further.
If you are starting from a clone of the latest devel, how should I be applying these? Just patch 2? Or 1 then 2? Either way, I'm getting rejects in both cases, so perhaps you want to try rebasing? Or is there a github repo I can pull from?
Also I would expect that cli_distro and similar files that have a reporting function are modified to reference the new reports? This seems like it would involve some changes to command.py
Anyhow, let me know if you can sort out the above, and if not, I can dig further and see what I can do. I'm sure it can be sorted out though if it's trivially solved with a rebase operation and then it all works that is easier than trying to apply it the hard way.
Thanks!
--Michael
cobbler@lists.fedorahosted.org