----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
locale: add tests covering timedate properties/methods
Diffs -----
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/#review3611 -----------------------------------------------------------
src/locale/test/testLocale.py http://reviewboard-openlmi.rhcloud.com/r/2206/#comment1978
Python has a convention of writing global variables in upper case.
src/locale/test/testLocale.py http://reviewboard-openlmi.rhcloud.com/r/2206/#comment1975
I'd make sure, that `LANG=C` is set.
src/locale/test/testLocale.py http://reviewboard-openlmi.rhcloud.com/r/2206/#comment1976
Magic that may fail with slightest change to the the output.
I'd at least use regular expression:
for line in tdctl_output.split("\n"): match = re.match(r'^\s*Local time\s*:\s*(.+?)\s*$', line, re.I) if match: return match.group(1)
src/locale/test/testLocale.py http://reviewboard-openlmi.rhcloud.com/r/2206/#comment1977
Again, let's be on a safe side with `LANG=C`.
src/locale/test/testLocale.py http://reviewboard-openlmi.rhcloud.com/r/2206/#comment1979
This is racy. `self.assertAlmostEqual()` allows you to use some delta. `self.assertLessEqual(first_obtained, second_obtained)` would be even better. You would have to convert strings to floats though.
- Michal Minar
On Lis. 13, 2014, 2:07 odp., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/
(Updated Lis. 13, 2014, 2:07 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
locale: add tests covering timedate properties/methods
Diffs
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/ -----------------------------------------------------------
(Updated Nov. 18, 2014, 1:37 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
locale: add tests covering timedate properties/methods
Diffs (updated) -----
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/ -----------------------------------------------------------
(Updated Nov. 18, 2014, 1:47 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
locale: add tests covering timedate properties/methods
Diffs (updated) -----
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing -------
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/#review3651 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Lis. 18, 2014, 1:47 odp., Vitezslav Crhonek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/
(Updated Lis. 18, 2014, 1:47 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
locale: add tests covering timedate properties/methods
Diffs
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing
Thanks,
Vitezslav Crhonek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2206/ -----------------------------------------------------------
(Updated Nov. 27, 2014, 12:53 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
locale: add tests covering timedate properties/methods
Diffs -----
src/locale/test/testLocale.py 12e5a66de79e28e2f7f572d528d24676c697c8aa
Diff: http://reviewboard-openlmi.rhcloud.com/r/2206/diff/
Testing -------
Thanks,
Vitezslav Crhonek
openlmi-reviews@lists.fedorahosted.org