-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/849/#review1153
-----------------------------------------------------------
src/hardware/LMI_PCIBridgeProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/849/#comment682>
This could be a shared variable for all hw providers. Initialized when the first
provider is instantiated and freed when the last one is cleaned up.
Although it would need a mutex as a guard.
src/hardware/LMI_PCIBridgeProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/849/#comment683>
Same code in src/hardware/LMI_PCIDeviceProvider.c
At least I would move these init functions to some shared module. And preferably make
just one taking enum of what needs to be filled.
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/849/#comment684>
Same code as in src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
- Michal Minar
On Sept. 10, 2013, 3:43 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/849/
-----------------------------------------------------------
(Updated Sept. 10, 2013, 3:43 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Move PCI bus initialization to the Initialize() function
Move initialize and cleanup code to the Initialize() and Cleanup() functions.
Diffs
-----
src/hardware/LMI_PCIBridgeProvider.c 33927728a856314cc2ad7b7df1222334fb15841a
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c
2151dd56a63240503ef966d198702d41dc3954c9
src/hardware/LMI_PCIDeviceProvider.c cc6adc815c4ced422fc17c8fa8080039d9096eaf
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
897f7bcad840512c82dacc95cba81c9728942990
Diff:
http://reviewboard-openlmi.rhcloud.com/r/849/diff/
Testing
-------
Thanks,
Peter Schiffer