----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Hardware: Added profile registration
Diffs -----
src/hardware/90_LMI_Hardware_Profile.mof.skel PRE-CREATION src/hardware/90_LMI_Hardware_Profile_DMTF.mof PRE-CREATION src/hardware/CMakeLists.txt 728c3d863935f81a8f353a5274f3062f457b09d6
Diff: http://reviewboard-openlmi.rhcloud.com/r/640/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/#review809 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On July 29, 2013, 1:30 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/
(Updated July 29, 2013, 1:30 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Hardware: Added profile registration
Diffs
src/hardware/90_LMI_Hardware_Profile.mof.skel PRE-CREATION src/hardware/90_LMI_Hardware_Profile_DMTF.mof PRE-CREATION src/hardware/CMakeLists.txt 728c3d863935f81a8f353a5274f3062f457b09d6
Diff: http://reviewboard-openlmi.rhcloud.com/r/640/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/#review811 -----------------------------------------------------------
src/hardware/CMakeLists.txt http://reviewboard-openlmi.rhcloud.com/r/640/#comment445
src/hardware/90_LMI_Hardware_Profile_DMTF.mof doesn't look it needs to be configured, there is no @SOMETHING@ replacement pattern, right?
- Radek Novacek
On July 29, 2013, 1:30 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/
(Updated July 29, 2013, 1:30 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Hardware: Added profile registration
Diffs
src/hardware/90_LMI_Hardware_Profile.mof.skel PRE-CREATION src/hardware/90_LMI_Hardware_Profile_DMTF.mof PRE-CREATION src/hardware/CMakeLists.txt 728c3d863935f81a8f353a5274f3062f457b09d6
Diff: http://reviewboard-openlmi.rhcloud.com/r/640/diff/
Testing
Thanks,
Peter Schiffer
On July 29, 2013, 1:47 p.m., Radek Novacek wrote:
src/hardware/CMakeLists.txt, line 37 http://reviewboard-openlmi.rhcloud.com/r/640/diff/1/?file=3572#file3572line37
src/hardware/90_LMI_Hardware_Profile_DMTF.mof doesn't look it needs to be configured, there is no @SOMETHING@ replacement pattern, right?
Correct. It's only copied to the destination.
- Peter
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/#review811 -----------------------------------------------------------
On July 29, 2013, 1:30 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/
(Updated July 29, 2013, 1:30 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Hardware: Added profile registration
Diffs
src/hardware/90_LMI_Hardware_Profile.mof.skel PRE-CREATION src/hardware/90_LMI_Hardware_Profile_DMTF.mof PRE-CREATION src/hardware/CMakeLists.txt 728c3d863935f81a8f353a5274f3062f457b09d6
Diff: http://reviewboard-openlmi.rhcloud.com/r/640/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/640/ -----------------------------------------------------------
(Updated July 29, 2013, 1:54 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Hardware: Added profile registration
Diffs -----
src/hardware/90_LMI_Hardware_Profile.mof.skel PRE-CREATION src/hardware/90_LMI_Hardware_Profile_DMTF.mof PRE-CREATION src/hardware/CMakeLists.txt 728c3d863935f81a8f353a5274f3062f457b09d6
Diff: http://reviewboard-openlmi.rhcloud.com/r/640/diff/
Testing -------
Thanks,
Peter Schiffer
openlmi-reviews@lists.fedorahosted.org