-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1305/#review1840
-----------------------------------------------------------
Autoscan finished with errors:
Error: NULL_RETURNS (CWE-476):
openlmi-networking-0.2.1_6_gd2e1900/src/LMI_BridgingSlaveSettingDataProvider.c:109:
returned_null: Function "connection_get_master_connection(Connection *)" returns
null.
openlmi-networking-0.2.1_6_gd2e1900/src/connection.c:231:9: return_null: Explicitly
returning null.
openlmi-networking-0.2.1_6_gd2e1900/src/LMI_BridgingSlaveSettingDataProvider.c:109:
dereference: Dereferencing a pointer that might be null
"connection_get_master_connection(old_connection)" when calling
"connection_set_master_connection(Connection *, Connection const *,
SettingType)".
openlmi-networking-0.2.1_6_gd2e1900/src/connection.c:209:5: deref_parm: Directly
dereferencing parameter "master".
Scanned reviews: 1304,1305,1306
- scanbot
On Nov. 28, 2013, 11:22 a.m., Radek Novacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1305/
-----------------------------------------------------------
(Updated Nov. 28, 2013, 11:22 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Use proper classname of slave SettingData in CreateSlaveSetting
CreateSlaveSetting must return only LMI_BridgingSlaveSettingData or
LMI_BondingSlaveSettingData instances.
Diffs
-----
src/LMI_IPNetworkConnectionCapabilitiesProvider.c
3d9201f554fd643e1b90cb94d318f3070d0710c0
test/test_bonding.py 2de8833e76a3706859f266f0aadacdf94a9f9609
test/test_bridging.py 0f780591ca28488268e0db66038c96da2f130cb4
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1305/diff/
Testing
-------
Thanks,
Radek Novacek