----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/#review2987 -----------------------------------------------------------
Autoscan started for review(s) 1872[1], 1873[1], 1874[1], 1875[1], 1876[1], 1877[1], 1878[1], 1879[1]
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/#review2997 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1872,1873,1874,1875,1876,1877,1878,1879
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/#review3006 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Čec. 9, 2014, 11:39 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/
(Updated Čec. 9, 2014, 11:39 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/#review3022 -----------------------------------------------------------
I decided to rework the whole architecture based on Steff's comments. The polkit agent can be part of lmipolkitmarker.
- Jan Safranek
On Čec. 9, 2014, 1:39 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/
(Updated Čec. 9, 2014, 1:39 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1879/ -----------------------------------------------------------
(Updated Čec. 10, 2014, 5:44 odp.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Add cmake rules to build the polkit stuff.
FindPAM.cmake is taken from kde-workspace-4.11.10.tar.xz
Diffs -----
CMakeLists.txt f2900abec0ba4b54fed481b7d1390eaed2ba1593 cmake/modules/FindPAM.cmake PRE-CREATION openlmi-providers.spec 5c22ac0ec19011647bb5353aafbc381875065816 src/CMakeLists.txt 0b8a8ff29c7a0c6af4ee2ba0025578c0659f3aa3 src/tools/CMakeLists.txt PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1879/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org