-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1279/#review1773
-----------------------------------------------------------
Autoscan finished with errors:
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_60_ga868f7e/src/account/LMI_AccountProvider.c:317:
branch_past_initialization: transfer of control bypasses initialization of:
openlmi-providers-0.4.1_60_ga868f7e/src/account/LMI_AccountProvider.c:317: caretline:
^
openlmi-providers-0.4.1_60_ga868f7e/src/account/LMI_AccountProvider.c:317:
name_at_decl_position: variable "groups" (declared at line 321)
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:355: branch_past_initialization:
transfer of control bypasses initialization of:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:355: caretline: ^
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:355: name_at_decl_position:
variable "i" (declared at line 380)
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:367: branch_past_initialization:
transfer of control bypasses initialization of:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:367: caretline: ^
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:367: name_at_decl_position:
variable "i" (declared at line 380)
Error: PW.BRANCH_PAST_INITIALIZATION:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:375: branch_past_initialization:
transfer of control bypasses initialization of:
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:375: caretline: ^
openlmi-providers-0.4.1_60_ga868f7e/src/hardware/sysfs.c:375: name_at_decl_position:
variable "i" (declared at line 380)
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_60_ga868f7e/src/indmanager/ind_manager.c:233: returned_null:
Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_60_ga868f7e/src/indmanager/ind_manager.c:233: var_assigned:
Assigning: "nd" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_60_ga868f7e/src/indmanager/ind_manager.c:234: dereference:
Dereferencing a null pointer "nd".
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:83: returned_null: Function
"malloc(size_t)" returns null.
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:83: var_assigned: Assigning:
"power" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:84: dereference: Dereferencing a
null pointer "power".
Error: FORWARD_NULL (CWE-476):
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:102: var_compare_op: Comparing
"_power" to null implies that "_power" might be null.
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:103: var_deref_op: Dereferencing
null pointer "_power".
Error: CLANG_WARNING:
openlmi-providers-0.4.1_60_ga868f7e/src/power/power.c:103:9: warning: Access to field
'instances' results in a dereference of a null pointer (loaded from variable
'_power')
# _power->instances++;
# ^~~~~~
- reviewbot
On Nov. 22, 2013, 3:17 p.m., Jan Safranek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1279/
-----------------------------------------------------------
(Updated Nov. 22, 2013, 3:17 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add covscan error
This patch will never be published, it here just to train reviewbot.
Diffs
-----
src/account/LMI_AccountProvider.c da7f97080047e83ec739acf9e6761a67e02466f2
src/indmanager/ind_manager.c cae141bd05a72b7635fdee45a64d9ae0d0405e4a
src/power/power.c 2b7e6dc6be974727ec97462a08a34e9ed8c02093
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1279/diff/
Testing
-------
Thanks,
Jan Safranek