On Aug. 26, 2013, 3:41 p.m., Radek Novacek wrote:
> src/logicalfile/LMI_DirectoryContainsFileProvider.c, line 162
>
<
http://reviewboard-openlmi.rhcloud.com/r/762/diff/1/?file=4300#file4300li...
>
> I would rather use strcmp() == 0 and strcmp() != 0.
> "if (strcmp())" looks like common error and it quite hard to read.
>
> But it's just minor nitpick.
That's true, I use strcmp() like that a lot throughout the whole provider. I'll
post a separate patch to deal with that.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/762/#review980
-----------------------------------------------------------
On Aug. 26, 2013, 3:26 p.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/762/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 3:26 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
logicalfile: correctly apply filters in LMI_DirectoryContainsFile
Diffs
-----
src/logicalfile/LMI_DirectoryContainsFileProvider.c
46db89177e6fc7f70f1ef49af7e4dadc9512c357
Diff:
http://reviewboard-openlmi.rhcloud.com/r/762/diff/
Testing
-------
Thanks,
Jan Synacek