-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/898/#review1258
-----------------------------------------------------------
DeleteInstance is dangerous, you cannot return an error code from it and you cannot make
it asynchronous in the future.
If it's just deletion of a route from Setting before it's applied, then it's
fine. But if the route is also deleted from NetworkManager, I'd rather make it
asynchronous and with proper return codes.
- Jan Safranek
On Sept. 30, 2013, 1:41 p.m., Radek Novacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/898/
-----------------------------------------------------------
(Updated Sept. 30, 2013, 1:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Implementation of route deletion
Static routes can now be deleted using DeleteInstance method.
Diffs
-----
src/LMI_IPRouteSettingDataProvider.c a10e5812e0b929547caee2d51b2f9e20610a76c4
src/setting.h 4291de0b0f0879f1ba8e086ac802a8aa58f416c0
src/setting.c 8ef76ad51b15b5727588ba504dad56c5ac209182
Diff:
http://reviewboard-openlmi.rhcloud.com/r/898/diff/
Testing
-------
Thanks,
Radek Novacek