----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2188/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Don't use upcalls for associations.
Reworked SELinux associations not to use LMI_SELinuxPort and LMI_SELinuxBooleans.EnumerateInstances().
It is very slow and in addition I've seen some deadlocks in Pegasus.
Also, I've found couple of memory leaks in SELinuxPort and SELinuxBoolean, they should free the values they get from libselinux / libsemanage.
Diffs -----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b src/selinux/LMI_SELinuxPortProvider.c 942a288d30b33618ffcb972fb4cd11b4faa42a35 src/selinux/LMI_SELinuxServiceHasElementProvider.c f1568a2a8a7a44b7e780c1a5abe65ad5dde823d1 src/selinux/selinux.h a89b0b5644366bf7afd48fb1f237f1e371e291ae src/selinux/selinux.c ffe8e14ff60a0fb2adb09a6b9be0bf6366979e57
Diff: http://reviewboard-openlmi.rhcloud.com/r/2188/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2188/#review3574 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On Nov. 6, 2014, 4:32 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2188/
(Updated Nov. 6, 2014, 4:32 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Don't use upcalls for associations.
Reworked SELinux associations not to use LMI_SELinuxPort and LMI_SELinuxBooleans.EnumerateInstances().
It is very slow and in addition I've seen some deadlocks in Pegasus.
Also, I've found couple of memory leaks in SELinuxPort and SELinuxBoolean, they should free the values they get from libselinux / libsemanage.
Diffs
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b src/selinux/LMI_SELinuxPortProvider.c 942a288d30b33618ffcb972fb4cd11b4faa42a35 src/selinux/LMI_SELinuxServiceHasElementProvider.c f1568a2a8a7a44b7e780c1a5abe65ad5dde823d1 src/selinux/selinux.h a89b0b5644366bf7afd48fb1f237f1e371e291ae src/selinux/selinux.c ffe8e14ff60a0fb2adb09a6b9be0bf6366979e57
Diff: http://reviewboard-openlmi.rhcloud.com/r/2188/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2188/ -----------------------------------------------------------
(Updated Lis. 7, 2014, 11:35 dop.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Don't use upcalls for associations.
Reworked SELinux associations not to use LMI_SELinuxPort and LMI_SELinuxBooleans.EnumerateInstances().
It is very slow and in addition I've seen some deadlocks in Pegasus.
Also, I've found couple of memory leaks in SELinuxPort and SELinuxBoolean, they should free the values they get from libselinux / libsemanage.
Diffs -----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b src/selinux/LMI_SELinuxPortProvider.c 942a288d30b33618ffcb972fb4cd11b4faa42a35 src/selinux/LMI_SELinuxServiceHasElementProvider.c f1568a2a8a7a44b7e780c1a5abe65ad5dde823d1 src/selinux/selinux.h a89b0b5644366bf7afd48fb1f237f1e371e291ae src/selinux/selinux.c ffe8e14ff60a0fb2adb09a6b9be0bf6366979e57
Diff: http://reviewboard-openlmi.rhcloud.com/r/2188/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org