----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Add polkit authorization.
Diffs -----
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/#review2988 -----------------------------------------------------------
Autoscan started for review(s) 1880[1]
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Add polkit authorization.
Diffs
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/#review2999 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1880
- scanbot
On July 9, 2014, 11:39 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/
(Updated July 9, 2014, 11:39 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Add polkit authorization.
Diffs
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/#review3007 -----------------------------------------------------------
Ship it!
src/cmpiLMI_Networking-cimprovagt http://reviewboard-openlmi.rhcloud.com/r/1880/#comment1689
execte ?
src/network.c http://reviewboard-openlmi.rhcloud.com/r/1880/#comment1688
I don't see any `lmi_polkit_shutdown()`, but I'm not sure whether it's an issue or not. It just seems weird.
- Michal Minar
On Čec. 9, 2014, 11:39 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/
(Updated Čec. 9, 2014, 11:39 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Add polkit authorization.
Diffs
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing
Thanks,
Jan Safranek
On Čec. 9, 2014, 3:56 odp., Michal Minar wrote:
src/cmpiLMI_Networking-cimprovagt, line 43 http://reviewboard-openlmi.rhcloud.com/r/1880/diff/1/?file=10957#file10957line43
execte ?
fixed
On Čec. 9, 2014, 3:56 odp., Michal Minar wrote:
src/network.c, line 152 http://reviewboard-openlmi.rhcloud.com/r/1880/diff/1/?file=10958#file10958line152
I don't see any `lmi_polkit_shutdown()`, but I'm not sure whether it's an issue or not. It just seems weird.
Some shutdown call added, but I am not sure it's the right place... let's wait for Radek for confirmation.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/#review3007 -----------------------------------------------------------
On Čec. 9, 2014, 1:39 odp., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/
(Updated Čec. 9, 2014, 1:39 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Add polkit authorization.
Diffs
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/ -----------------------------------------------------------
(Updated Čec. 10, 2014, 10:42 dop.)
Review request for OpenLMI Developers.
Changes -------
Updated with review remarks.
Summary (updated) -----------------
openlmi-networking: polkit Add polkit authorization.
Repository: openlmi-networking
Description -------
Add polkit authorization.
Diffs (updated) -----
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/#review3023 -----------------------------------------------------------
I decided to rework the whole architecture based on Steff's comments. The polkit agent can be part of lmipolkitmarker.
- Jan Safranek
On Čec. 10, 2014, 10:42 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/
(Updated Čec. 10, 2014, 10:42 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Add polkit authorization.
Diffs
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1880/ -----------------------------------------------------------
(Updated Čec. 10, 2014, 5:45 odp.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Add polkit authorization.
Diffs -----
CMakeLists.txt 1b5147d99791fdc06bb8ed6c79ec5a3ffad25c62 openlmi-networking.spec e067ad70eff454bea6d38b773a83bbb9a57ad1c4 src/CMakeLists.txt 9b3f8c4be731fdde15052a3f34b05c6cfa38abdd src/cmpiLMI_Networking-cimprovagt 4079cbb640d2ee112c10dc7a1c4ce8f8f9dd1137 src/network.c 4f53e516b0bc68ecc6c6766c1f4bf9cb450e3745 src/unittest/CMakeLists.txt 0eae14e11e4c729e3f7e7522ec43ce41b62f2752
Diff: http://reviewboard-openlmi.rhcloud.com/r/1880/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org