----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs -----
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/#review2967 -----------------------------------------------------------
Autoscan started for review(s) 1868[1], 1869[1]
- scanbot
On July 4, 2014, 1:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/
(Updated July 4, 2014, 1:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/#review2970 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1868,1869
- scanbot
On July 4, 2014, 1:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/
(Updated July 4, 2014, 1:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/#review2972 -----------------------------------------------------------
mof/60_LMI_Software_MethodParameters.mof http://reviewboard-openlmi.rhcloud.com/r/1869/#comment1651
s/theinstall/the install/
- Jan Synacek
On July 4, 2014, 3:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/
(Updated July 4, 2014, 3:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/#review2973 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On July 4, 2014, 3:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/
(Updated July 4, 2014, 3:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1869/ -----------------------------------------------------------
(Updated Čec. 8, 2014, 11:14 dop.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
software-dbus: fill input parameters of job to CIM instance
Declared input parameters of LMI_SoftwareInstallationService.InstallFromSoftwareIdentity in corresponding __MethodParameters_InstallFromSoftwareIdentity class in mof file. This allows client to query input parameters of job.
Fixed making input parameters of software job.
Diffs -----
mof/60_LMI_Software_MethodParameters.mof b4ef525e50ccca74e16489ba198f7f7de1a42a84 src/software-dbus/lmi_sw_job.c a74161026ab2ca3b71f795fdd8c4cc7283c6cbd4
Diff: http://reviewboard-openlmi.rhcloud.com/r/1869/diff/
Testing -------
Thanks,
Michal Minar
openlmi-reviews@lists.fedorahosted.org