-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1666/#review2572
-----------------------------------------------------------
Ship it!
Thanks!
src/libs/libopenlmi/openlmi.h
<
http://reviewboard-openlmi.rhcloud.com/r/1666/#comment1399>
Just a nitpick.
Consider wrapping "st" in brackets. Sometimes we work with a pointer to
status (passed as a parameter of function) resulting in a call
lmi_return_if_status_not_ok(*status);
Without brackets, compiler would scold us.
src/libs/libopenlmi/openlmi.h
<
http://reviewboard-openlmi.rhcloud.com/r/1666/#comment1400>
Wrap "st" in brackets.
- Michal Minar
On May 5, 2014, 1:33 p.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1666/
-----------------------------------------------------------
(Updated May 5, 2014, 1:33 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
lmiopenlmi: minor fixes and improvements
Diffs
-----
src/account/LMI_AccountCapabilitiesProvider.c 0aea4057d5a927d8a68d982d225d9f02c41246ad
src/account/LMI_AccountManagementServiceCapabilitiesProvider.c
84a0921728e8ec338d74f1b6678877f68afa90bc
src/account/LMI_AccountManagementServiceProvider.c
e0e6f896d7e74266c6e710597a0ae014be5dd742
src/account/LMI_AccountOnSystemProvider.c 9c5960b3abf94b4e6faa19f3f9393602e5936e93
src/account/LMI_AccountProvider.c fcfde9edfaf9bb08d2891219ab6add0a4be9eca1
src/account/LMI_AssignedAccountIdentityProvider.c
80a89157334cfd52fe8a6f12fa295034ed4536df
src/account/LMI_HostedAccountManagementServiceProvider.c
89fdcf36dfafcfdf55c2dff8f068351f965c6da7
src/account/LMI_ServiceAffectsIdentityProvider.c
5d302a29a2c12ecda6b117c3f4061bd2bfba00eb
src/fan/LMI_FanAssociatedSensorProvider.c 5879118e7d62336b84e2d8bcb78518b4063f739c
src/fan/LMI_FanProvider.c 3d7145b55ff4101c26b5651e884ed1ead00a96c7
src/fan/LMI_FanSensorProvider.c 0df31ffa2dbb44c0e8b2642f8758ce7a680be7e6
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c
9c627a947238cd0f3f604d7e29a16df05dc745e7
src/hardware/LMI_BatteryProvider.c 4996c8ea1ad70e8b7d09596e16643a0785c36822
src/hardware/LMI_BatterySystemDeviceProvider.c 90a2076f6c35ca9665650567e8beec8aabc8dbed
src/hardware/LMI_DiskDriveATAPortProvider.c 56a1aa7d878e88872108abd1dc7e8b6a6bdb6b35
src/hardware/LMI_DiskDriveATAProtocolEndpointProvider.c
089f8c6d39b594405dc94013b7efbac1fd248f75
src/hardware/LMI_DiskDriveDeviceSAPImplementationProvider.c
ab4ee900e5c7835e86774b1770084c77bc69b774
src/hardware/LMI_DiskDriveElementSoftwareIdentityProvider.c
e07e2eda0023f8b671291691e129ea67cff4bf53
src/hardware/LMI_DiskDriveProvider.c 5a28a0a87fdfa4dfd401fdbd92f5f1914b806a86
src/hardware/LMI_DiskDriveRealizesProvider.c 2756dec55ad26c7cf7a4a1f5b30ce0243368bf42
src/hardware/LMI_DiskDriveSAPAvailableForElementProvider.c
51b5f444b6ca55d4cfd2b7a96802faa815daa7be
src/hardware/LMI_DiskDriveSystemDeviceProvider.c
87fc99dbfef6423a4541e5e7b34a897517894b1a
src/hardware/LMI_MemoryProvider.c 4626beab37345759e2d9859b5e96016b8a6eb5d1
src/hardware/LMI_MemorySystemDeviceProvider.c 0c3c7c5f258ade69f5406a9d4e6aeac301749396
src/hardware/LMI_PCIBridgeProvider.c ee8aa50320b8010131d12cd0efa2b3c9b54400d0
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c
c413d1f9ff1d184c3ef471ed96c86b26379e313f
src/hardware/LMI_PCIDeviceProvider.c e2d0e55ec0dee37a49b030c94caa394eb859337f
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
7231c083ee4a925fd6bc0de268209d697c7529c2
src/hardware/LMI_PhysicalBatteryRealizesProvider.c
5cc6afba4a7b8c3ad9231f4379cc4963d2bb634d
src/hardware/LMI_PhysicalMemoryRealizesProvider.c
9128450d3a1a65cca80c340f8eaa27a4f8f905cb
src/hardware/LMI_PointingDeviceProvider.c 1b169dfa0c95c3c7f31250bd4bd1963b2ddaf050
src/hardware/LMI_ProcessorCacheMemoryProvider.c
2365856589792431be3eaee6c8abc9a5d736e0ea
src/hardware/LMI_ProcessorChipRealizesProvider.c
e1b0bedd677e01992f91e23c83e2adcc708e066d
src/hardware/LMI_ProcessorElementCapabilitiesProvider.c
5ec6a964b5687b045242127824d93b54f6d92284
src/hardware/LMI_ProcessorProvider.c 67d1987a4d45f9c8761f1fbe3e69ab487824d267
src/hardware/LMI_ProcessorSystemDeviceProvider.c
e8ac4929721685a523b1a57a57628a30753eb5b4
src/libs/libopenlmi/openlmi.h 7f151cd9f4ba19186688783349e97d9cb20e4b26
src/libs/libopenlmi/openlmi.c 6257520fe7f8607c95eb86c4364168764ab51a42
src/logicalfile/LMI_DataFileProvider.c cef32193dbbc5c9437747cb5888385f6790e29bf
src/logicalfile/LMI_DirectoryContainsFileProvider.c
bcf6d14b53a304405b4bdfc0b80af30a52bd8412
src/logicalfile/LMI_FIFOPipeFileProvider.c 1330f56984cf3d44eea44393ffe8e2ac46d4da6e
src/logicalfile/LMI_FileIdentityProvider.c b1a8599e2ea7241873df3ea3b2ca5eb70faef570
src/logicalfile/LMI_RootDirectoryProvider.c 4ada3f513929537046923585332d1fe473c7a6f0
src/logicalfile/LMI_SymbolicLinkProvider.c 68a61428b5840143b621f3e61ce1115779d37854
src/logicalfile/LMI_UnixDeviceFileProvider.c 3062094a104d640c61151d2cb1ec2d906cc3a733
src/logicalfile/LMI_UnixDirectoryProvider.c 1ca995b4a149a5e5afc84200405d3c52e6ece431
src/logicalfile/LMI_UnixFileProvider.c 52e7b9c61a2ed02227061f188908f8d5375692a1
src/logicalfile/LMI_UnixSocketProvider.c d19753c0797b60311a73dbdb5232c1b213348aa8
src/logicalfile/file.h a5291ed92d31935d82352b20e4b2cdaa75197541
src/logicalfile/file.c 03c99da63b1de2f333d2b394b99347b1b603e73c
src/power/LMI_AssociatedPowerManagementServiceProvider.c
25cfc9c3de58890bee2286c61b3416215c123adc
src/power/LMI_ElementCapabilitiesProvider.c 7d7d58fff4447cee973d420648b8a65a76f671ec
src/power/LMI_HostedPowerManagementServiceProvider.c
80f011189f730620683b16812daa4c10b93976ec
src/power/LMI_PowerManagementServiceProvider.c 162d798a6bbfaf17b0219d7e259ec5af6c340982
src/realmd/LMI_HostedRealmdServiceProvider.c eecedbb6871b81f00e82546fba06025e480d610e
src/realmd/LMI_RealmdServiceProvider.c d69e290e2d2f38fb9c6006d2ed36ed7138ce8ea6
src/realmd/rdcp_util.h c45fb7324e028f0270827d9f96e9029baba23568
src/service-dbus/LMI_ServiceProvider.c 1f370c1585a345547be9a3a96f0b4043ef5c624a
src/service/LMI_ServiceProvider.c 355e49cbf92767d731acf119c67c75278b3ca8f0
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c
fec2794131a6194510364e45969995729e80108c
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1666/diff/
Testing
-------
Thanks,
Jan Synacek