On July 26, 2013, 10:06 a.m., Jan Safranek wrote:
> mof/60_LMI_Hardware.mof, line 166
>
<
http://reviewboard-openlmi.rhcloud.com/r/604/diff/1/?file=3487#file3487li...
>
> I would use SystemProcessorDevice, SystemPCIDevice, SystemBatteryDevice.
PCIDeviceSystemDevice sounds really weird, but who cares...
Yes, I agree with you, but this pattern is used in general in Hardware providers, so..
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/604/#review754
-----------------------------------------------------------
On July 25, 2013, 8:42 p.m., Peter Schiffer wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/604/
-----------------------------------------------------------
(Updated July 25, 2013, 8:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added associations to the CIM_ComputerSystem class
New providers:
* LMI_ProcessorSystemDeviceProvider
* LMI_MemorySystemDeviceProvider
* LMI_PCIDeviceSystemDeviceProvider
* LMI_BatterySystemDeviceProvider
* LMI_ChassisComputerSystemPackageProvider
Diffs
-----
mof/60_LMI_Hardware.mof 74b85a2c897e444e660f89d1b6511662edc2d727
src/hardware/LMI_BatterySystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_ChassisComputerSystemPackageProvider.c PRE-CREATION
src/hardware/LMI_Hardware.h 1361dd49b9a2cbfe8744c222dc323a52b69a3726
src/hardware/LMI_MemorySystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_PCIDeviceProvider.c 2daf0a6420a313c8c26aa08bd59da8a0c99c6408
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c PRE-CREATION
src/hardware/LMI_ProcessorSystemDeviceProvider.c PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/604/diff/
Testing
-------
Thanks,
Peter Schiffer