----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
jobmanager: allow to fill input parameters of job
Leave up to provider's implementation whether the input parameters shall be filled or not. This change affects contents of following properties:
* LMI_ConcreteJob.JobInParameters * will be filled if method-name property of job is set * will always be an instance of __MethodParameters_<MethodName> * CIM_InstMethodCall.MethodParameters * will be filled if method-name property of job is set * will be an instance of: * __MethodParameters_<MethodName>_Result if the job is completed and CIM_InstMethodCall represents a "post call indication" (see description of CIM_MethodResult.PostCallIndication property) * __MethodParameters_<MethodName> otherwise
Previously JobInParameters were unset.
Provider needs to register two CIM classes for each asynchronous method they implement:
__MethodParameters_<MethodName> and __MethodParameters_<MethodName>_Result
The latter inherits from the former. The former shall declare all input parameters of particular method as its properties. The latter shall do the same for all the output parameters except for `Job` and add one more special `__ReturnValue` property of type `uint32` that will contain the result of method as if it was invoked synchronously.
Diffs -----
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
Diff: http://reviewboard-openlmi.rhcloud.com/r/1868/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/#review2966 -----------------------------------------------------------
Autoscan started for review(s) 1868[1], 1869[1]
- scanbot
On July 4, 2014, 1:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/
(Updated July 4, 2014, 1:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
jobmanager: allow to fill input parameters of job
Leave up to provider's implementation whether the input parameters shall be filled or not. This change affects contents of following properties:
* LMI_ConcreteJob.JobInParameters * will be filled if method-name property of job is set * will always be an instance of __MethodParameters_<MethodName> * CIM_InstMethodCall.MethodParameters * will be filled if method-name property of job is set * will be an instance of: * __MethodParameters_<MethodName>_Result if the job is completed and CIM_InstMethodCall represents a "post call indication" (see description of CIM_MethodResult.PostCallIndication property) * __MethodParameters_<MethodName> otherwise
Previously JobInParameters were unset.
Provider needs to register two CIM classes for each asynchronous method they implement:
__MethodParameters_<MethodName> and __MethodParameters_<MethodName>_Result
The latter inherits from the former. The former shall declare all input parameters of particular method as its properties. The latter shall do the same for all the output parameters except for `Job` and add one more special `__ReturnValue` property of type `uint32` that will contain the result of method as if it was invoked synchronously.
Diffs
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
Diff: http://reviewboard-openlmi.rhcloud.com/r/1868/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/#review2969 -----------------------------------------------------------
Autoscan failed: FAILED This can indicate any failure like broken buildroot to patch failed to apply. Manual investigation of scan log is needed. Scanned reviews: 1868,1869
- scanbot
On July 4, 2014, 1:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/
(Updated July 4, 2014, 1:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
jobmanager: allow to fill input parameters of job
Leave up to provider's implementation whether the input parameters shall be filled or not. This change affects contents of following properties:
* LMI_ConcreteJob.JobInParameters * will be filled if method-name property of job is set * will always be an instance of __MethodParameters_<MethodName> * CIM_InstMethodCall.MethodParameters * will be filled if method-name property of job is set * will be an instance of: * __MethodParameters_<MethodName>_Result if the job is completed and CIM_InstMethodCall represents a "post call indication" (see description of CIM_MethodResult.PostCallIndication property) * __MethodParameters_<MethodName> otherwise
Previously JobInParameters were unset.
Provider needs to register two CIM classes for each asynchronous method they implement:
__MethodParameters_<MethodName> and __MethodParameters_<MethodName>_Result
The latter inherits from the former. The former shall declare all input parameters of particular method as its properties. The latter shall do the same for all the output parameters except for `Job` and add one more special `__ReturnValue` property of type `uint32` that will contain the result of method as if it was invoked synchronously.
Diffs
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
Diff: http://reviewboard-openlmi.rhcloud.com/r/1868/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/#review2971 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On July 4, 2014, 3:39 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/
(Updated July 4, 2014, 3:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
jobmanager: allow to fill input parameters of job
Leave up to provider's implementation whether the input parameters shall be filled or not. This change affects contents of following properties:
* LMI_ConcreteJob.JobInParameters * will be filled if method-name property of job is set * will always be an instance of __MethodParameters_<MethodName> * CIM_InstMethodCall.MethodParameters * will be filled if method-name property of job is set * will be an instance of: * __MethodParameters_<MethodName>_Result if the job is completed and CIM_InstMethodCall represents a "post call indication" (see description of CIM_MethodResult.PostCallIndication property) * __MethodParameters_<MethodName> otherwise
Previously JobInParameters were unset.
Provider needs to register two CIM classes for each asynchronous method they implement:
__MethodParameters_<MethodName> and __MethodParameters_<MethodName>_Result
The latter inherits from the former. The former shall declare all input parameters of particular method as its properties. The latter shall do the same for all the output parameters except for `Job` and add one more special `__ReturnValue` property of type `uint32` that will contain the result of method as if it was invoked synchronously.
Diffs
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
Diff: http://reviewboard-openlmi.rhcloud.com/r/1868/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1868/ -----------------------------------------------------------
(Updated Čec. 8, 2014, 11:14 dop.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
jobmanager: allow to fill input parameters of job
Leave up to provider's implementation whether the input parameters shall be filled or not. This change affects contents of following properties:
* LMI_ConcreteJob.JobInParameters * will be filled if method-name property of job is set * will always be an instance of __MethodParameters_<MethodName> * CIM_InstMethodCall.MethodParameters * will be filled if method-name property of job is set * will be an instance of: * __MethodParameters_<MethodName>_Result if the job is completed and CIM_InstMethodCall represents a "post call indication" (see description of CIM_MethodResult.PostCallIndication property) * __MethodParameters_<MethodName> otherwise
Previously JobInParameters were unset.
Provider needs to register two CIM classes for each asynchronous method they implement:
__MethodParameters_<MethodName> and __MethodParameters_<MethodName>_Result
The latter inherits from the former. The former shall declare all input parameters of particular method as its properties. The latter shall do the same for all the output parameters except for `Job` and add one more special `__ReturnValue` property of type `uint32` that will contain the result of method as if it was invoked synchronously.
Diffs -----
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
Diff: http://reviewboard-openlmi.rhcloud.com/r/1868/diff/
Testing -------
Thanks,
Michal Minar
openlmi-reviews@lists.fedorahosted.org