----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2189/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Initialize the XML parser only once.
There can be multiple threads running EnumerateInstances, thereforce any xmlInitParser() call must be outside of it.
Multiple xmlInitParser() in different threads may clash, leading to hard to debug sigsegv.
Diffs -----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
Diff: http://reviewboard-openlmi.rhcloud.com/r/2189/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2189/#review3575 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On Nov. 6, 2014, 4:32 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2189/
(Updated Nov. 6, 2014, 4:32 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Initialize the XML parser only once.
There can be multiple threads running EnumerateInstances, thereforce any xmlInitParser() call must be outside of it.
Multiple xmlInitParser() in different threads may clash, leading to hard to debug sigsegv.
Diffs
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
Diff: http://reviewboard-openlmi.rhcloud.com/r/2189/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2189/ -----------------------------------------------------------
(Updated Lis. 7, 2014, 11:35 dop.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Initialize the XML parser only once.
There can be multiple threads running EnumerateInstances, thereforce any xmlInitParser() call must be outside of it.
Multiple xmlInitParser() in different threads may clash, leading to hard to debug sigsegv.
Diffs -----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
Diff: http://reviewboard-openlmi.rhcloud.com/r/2189/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org