Review Request 1933: software-dbus [1/3] software-dbus: rename cleanup function of SwPackage
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1933/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: rename cleanup function of SwPackage
Fuctions prefixed with `free_` with single pointer argument are used to
release all resources referenced by data structure and to release the
data itself. SwPackage is usually statically allocated and therefor
it needs only to be cleared, not freed entirely. `clean_sw_package()`
buetter describes what the function does.
Diffs
-----
src/software-dbus/LMI_AffectedSoftwareJobElementProvider.c eb03358db0a870addb7bd1b8a436e970b605a8f2
src/software-dbus/LMI_InstalledSoftwareIdentityProvider.c 0658367cb72e346b23cd016d10f35cb9a3066249
src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c 84cea07bf1d65c8ff2c9cc98bf9f236a899be9eb
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareIdentityCheckUnixFileProvider.c 2af014a65da766a78a23ce5ec3693893de4eaff2
src/software-dbus/LMI_SoftwareIdentityChecksProvider.c a00a67f8948a5b56c6a3338ce74b1845dc69612c
src/software-dbus/LMI_SoftwareIdentityProvider.c db07d63cc0d72001a73f7d73d412590d3c7fa369
src/software-dbus/LMI_SoftwareInstallationServiceProvider.c b629f5f92d3611c97425144bed444886cb1c3482
src/software-dbus/lmi_sw_job.c 7bcbb8d917286bf21815843a7b5dc806a16d5149
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1933/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 9 months
Review Request 1932: jobmgr: don't truncate GType's value
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1932/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
jobmgr: don't truncate GType's value
GType is a long integer that can not be treated as an unsigned int. Full
pointer length needs to be utilized when used as key of binary tree to
avoid colisions.
Diffs
-----
src/libs/jobmanager/job_manager.c a5a0e8d1ed3a9a05ae4c9a3d2606a87fa4fcc28d
src/libs/libopenlmi/openlmi-utils.h d3245e7ee8e51144c5c939c816bb1a4cfb76b774
src/libs/libopenlmi/openlmi-utils.c 20348b23a305d4c237cfc1322ae4ed9e5e9195c1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1932/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 9 months