Review Request 1863: indication-sending-done-right [2/2] software-dbus: adjust init/cleanup due to api change
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1863/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: adjust init/cleanup due to api change
Provider initialization and cleanup functions needs to be tuned due to
api change in job manager.
"provider_name" variable in sw-utils.h is renamed to "profile_name" which
better describes what it is.
Diffs
-----
src/software-dbus/LMI_SoftwareInstCreationProvider.c f1a18524f3e28b5c6de9996cd887aaef88125e23
src/software-dbus/LMI_AssociatedSoftwareJobMethodResultProvider.c 4120358d4424f5288dc11f67183b30fb8dcce87a
src/software-dbus/LMI_HostedSoftwareCollectionProvider.c fad7db6fc42ae1823140665c59f9a40d5ba3e711
src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c 50b8030fe4cbdafb408204efafdfbd74981f1f5a
src/software-dbus/LMI_InstalledSoftwareIdentityProvider.c 428515ed2d67ef6b7bfec7ad58ea5423204a86dc
src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c 05d03c7ce39ffa43503507a816b61e5b1be65908
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 1944f0b16f295e723187fd70a324e3cc5c8ae263
src/software-dbus/LMI_SoftwareIdentityChecksProvider.c a90fbb83a1dff4d96b859ad3f15799f8baf314e8
src/software-dbus/LMI_SoftwareIdentityFileCheckProvider.c ca6af590f918297841447964a1f00aafa7027300
src/software-dbus/LMI_SoftwareIdentityProvider.c 7074be640a53e43903f7a82e84bbe77b0772abcd
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c 01a39902ffcc6a4d344e8a1eb60361908c6cf17a
src/software-dbus/LMI_SoftwareInstallationJobProvider.c f0b7327beb6b4f00a546c916f238a0650faffd57
src/software-dbus/LMI_SoftwareInstallationServiceCapabilitiesProvider.c 92f95bc6362386501b4f799429a361eeaf43c961
src/software-dbus/LMI_SoftwareInstallationServiceProvider.c 18648636a970e4542417d4d0f0b80eae7e865475
src/software-dbus/LMI_AssociatedSoftwareInstallationServiceCapabilitiesProvider.c c49daf308eb358ec8ac564b4d4510a61bfe238b1
src/software-dbus/LMI_AffectedSoftwareJobElementProvider.c d08acc348a9f7e147814c80f16dc8b5399b018b1
src/software-dbus/LMI_SystemSoftwareCollectionProvider.c 888ac999d82d024e0680f338e973ee2304e99377
src/software-dbus/LMI_SoftwareMethodResultProvider.c 009daac38bbdeb3b3ba47d0e6b9a522068abbfcf
src/software-dbus/LMI_SoftwareInstModificationProvider.c ce232aaee1b0f7f02313d11e636f8fa202da9f48
src/software-dbus/sw-utils.h 289cf7389c04eb10d3141759ff020cbf6cb7863a
src/software-dbus/sw-utils.c 5a8c4c21428d91fd570328549aaba81283e39414
Diff: http://reviewboard-openlmi.rhcloud.com/r/1863/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 11 months
Review Request 1862: indication-sending-done-right [1/2] jobmanager: fixed indication sending
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1862/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
jobmanager: fixed indication sending
* API change!
- each provider needs to pass two more arguments to init() function
and one more argument to cleanup()
- Job Manager needs to be passed provider name (in provider module,
generated by konkret, it's a third argument of `KONKRET_REGISTER`).
Broker object given to provider implementing indication class must
be used as an argument to CMDeliverIndication() for corresponding
indication class being sent. Therefor Job Manager needs to be
passed this information to associate correct broker object with CIM
indication class.
* renamed locking macros
* created a helper function for indication sending in job manager
Diffs
-----
src/libs/libopenlmi/openlmi-utils.c 0e5b687b3af9a734c536c40a9ecbf7270c6bb409
src/libs/jobmanager/job_manager.c bc13d2162ea4c27d2bfe0851bfab436f8d176abc
src/libs/jobmanager/job_manager.h 125fb99c01fc310571924a110fb33ee297223df8
src/libs/libopenlmi/openlmi-utils.h 9af64e502c6f76a74ad968507aba61443b9410cf
Diff: http://reviewboard-openlmi.rhcloud.com/r/1862/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 11 months