-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1738/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
The string conversion was not working at all, we were accessing
already freed memory.
--
NB: cherry-pick to stable.
Diffs
-----
src/journald/instutil.c b2ed0e74f496054f77d96902500f38bde95a6246
Diff: http://reviewboard-openlmi.rhcloud.com/r/1738/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1664/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
A bit of code shuffling, to include local profile (un)registration.
Requires recent openlmi-providers (git master, future 0.5.0?)
Diffs
-----
src/CMakeLists.txt 854d0b80283710b812a3f8f5b9b5b83dd656c5ed
Diff: http://reviewboard-openlmi.rhcloud.com/r/1664/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is an attempt to include profile (un)registration within the
(un)register-PROVIDER make target. This commit extends the cim_registration
macro by an extra argument of the profile file. However it is currently
limited to a single argument.
Diffs
-----
cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa
src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01
src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69
src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f
src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69
src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde
src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2
src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11
src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098
src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9
src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e
Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1728/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
According to the Simple Identity Management Profile (DSP1034)
document the LMI_Account.UserPassword property should not contain
the password itself, no matter how encrypted it is. It should either
contain an array of zero elements when password has been set or
NULL when password is missing or not configured.
Another change this commit brings is a more precise behaviour
of LMI_Account.ModifyInstance() method. When the UserPassword
property is array of zero elements, no change regarding password
is made. This case was previously treated as a request for password
removal. The DSP1034 profile doesn't specify such scenario, let's
treat it the same way as the GetInstance() operation.
Diffs
-----
mof/60_LMI_Account.mof 6bc99c8cbea85b556cfcb073af08e63c089791d9
src/account/LMI_AccountProvider.c fdb06fffe99198b469def5de91508a766a6a7ecf
Diff: http://reviewboard-openlmi.rhcloud.com/r/1728/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1690/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Testing wrong return code when sd_journal_next() was not called as it
was not needed. When step_next == FALSE the EOF flag must be never set
since the journal EOF case is tested at the beginning of the function
and we're not advancing next thus staying on a valid cursor.
--
found by failing tests, should check them more often :-o
BTW I'm not adding any tests regarding the journal EOF case as they would be racy from nature on a live (system) journal.
Diffs
-----
src/journald/instutil.c b2ed0e74f496054f77d96902500f38bde95a6246
Diff: http://reviewboard-openlmi.rhcloud.com/r/1690/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1686/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
indmanager: Add a Debugging section in the README file
Diffs
-----
src/libs/indmanager/README 4f9654d9584d26cedb23e59341b1f31f6b956692
Diff: http://reviewboard-openlmi.rhcloud.com/r/1686/diff/
Testing
-------
Thanks,
Tomáš Bžatek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1730/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Clean up imports in common
Diffs
-----
src/account/test/common.py 95abd381089506c3f9b4d6632f2303da322fa585
src/python/lmi/test/util.py 699507c2340e9a50ff22ce08b67fe3e0a3f9eef8
Diff: http://reviewboard-openlmi.rhcloud.com/r/1730/diff/
Testing
-------
Thanks,
Alois Mahdal
The Buildbot has detected a failed build on builder storage-rawhide while building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/storage-rawhide/builds/392
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rawhide-slave
Build Reason: The Nightly scheduler named 'storage nightly' triggered this build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed run scripts tests selinux check
sincerely,
-The Buildbot
The Buildbot has detected a failed build on builder providers-rawhide while building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/providers-rawhide/builds/630
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rawhide-slave
Build Reason: The Nightly scheduler named 'providers nightly' triggered this build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed tests run scripts tests selinux check
sincerely,
-The Buildbot