Review Request 1649: devassistant: Fix template files file mode
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1649/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
commit 47f95fb947cf387de2d798cb30c3308a1d713bd6
Author: Tomas Bzatek <tbzatek(a)redhat.com>
Date: Mon Apr 28 16:44:35 2014 +0200
devassistant: Fix template files file mode
To fix
E: non-executable-script /usr/share/devassistant/files/crt/c/openlmi/src/cmpiLMI_{{PROJECT_NAME}}-cimprovagt 0644L /bin/sh
diff --git a/tools/devassistant/files/crt/c/openlmi/src/cmpiLMI_{{PROJECT_NAME}}-cimprovagt b/tools/devassistant/files/crt/c/openlmi/src/cmpiLMI_{{PROJECT_NAME}}-cimprovagt
old mode 100644
new mode 100755
-- I seem not to be able to upload a diff since it's treated as empty. A shortcoming of the RB system probably.
Diffs
-----
Diff: http://reviewboard-openlmi.rhcloud.com/r/1649/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years
Review Request 1648: devassistant: Add support for creating new scripts
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This snippet first clones the upstream openlmi-scripts repo and uses
the make_new.py script to create new command. The generated structure
is independent from the openlmi-scripts repo and only depends on
openlmi-tools.
Diffs
-----
tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION
tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years
Review Request 1667: Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1667/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 9332f62e392103e39a700cedcfaadf72df8e5f53
src/software-dbus/LMI_SoftwareIdentityProvider.c 7e03badf0113ebc981a24d20ccac60131dfb8d74
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c fec2794131a6194510364e45969995729e80108c
src/software-dbus/sw-utils.h 16e6ca11e4714ab337c7e554f7c8ced5b06bd37b
src/software-dbus/sw-utils.c 76ca58bd0129c3d12695d22da77fb3613c8685b1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1667/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years
Review Request 1676: Improve random_string util function
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1676/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
When writing new test, I find myself constantly computing the
size from desired strength and prefix length, whereas I mostly
don't care about the final size at all (plus, one can usually
see that from surrounding code).
Providing strength simplifies use and the function code.
Diffs
-----
src/account/test/TestAccountRaceConditions.py 6125bd3e4cc0830acf7dc5a747a872ec3f17b5c9
src/account/test/common.py 862d1d43f398646302ce2b7cbd25a510cedcea92
src/account/test/methods.py 9c033c5e8494edba2fa7a38046beda577458e09f
Diff: http://reviewboard-openlmi.rhcloud.com/r/1676/diff/
Testing
-------
Thanks,
Alois Mahdal
10 years