Review Request 2189: Initialize the XML parser only once.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/2189/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Initialize the XML parser only once.
There can be multiple threads running EnumerateInstances, thereforce
any xmlInitParser() call must be outside of it.
Multiple xmlInitParser() in different threads may clash, leading to hard to
debug sigsegv.
Diffs
-----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
Diff: http://reviewboard-openlmi.rhcloud.com/r/2189/diff/
Testing
-------
Thanks,
Jan Safranek
9 years, 7 months
Review Request 2188: Don't use upcalls for associations.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/2188/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Don't use upcalls for associations.
Reworked SELinux associations not to use LMI_SELinuxPort and
LMI_SELinuxBooleans.EnumerateInstances().
It is very slow and in addition I've seen some deadlocks in Pegasus.
Also, I've found couple of memory leaks in SELinuxPort and SELinuxBoolean,
they should free the values they get from libselinux / libsemanage.
Diffs
-----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
src/selinux/LMI_SELinuxPortProvider.c 942a288d30b33618ffcb972fb4cd11b4faa42a35
src/selinux/LMI_SELinuxServiceHasElementProvider.c f1568a2a8a7a44b7e780c1a5abe65ad5dde823d1
src/selinux/selinux.h a89b0b5644366bf7afd48fb1f237f1e371e291ae
src/selinux/selinux.c ffe8e14ff60a0fb2adb09a6b9be0bf6366979e57
Diff: http://reviewboard-openlmi.rhcloud.com/r/2188/diff/
Testing
-------
Thanks,
Jan Safranek
9 years, 7 months
Review Request 2182: Fixed some memory leaks in SELinux provider.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/2182/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Fixed some memory leaks in SELinux provider.
Every semanage_connect must have semanage_disconnect.
Resolves: ticket#339
Diffs
-----
src/selinux/LMI_SELinuxBooleanProvider.c 4b0ab283183200fffd3ff3d5dd4acfc9ddf30f3b
src/selinux/LMI_SELinuxPortProvider.c 942a288d30b33618ffcb972fb4cd11b4faa42a35
src/selinux/selinux.c ffe8e14ff60a0fb2adb09a6b9be0bf6366979e57
Diff: http://reviewboard-openlmi.rhcloud.com/r/2182/diff/
Testing
-------
Thanks,
Jan Safranek
9 years, 7 months