Review Request 1170: providers-tests [4/5] software: refactored tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1170/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: refactored tests
Base software tests on LmiTestCase from lmi.test.base. Use lmi.shell
abstractions instead of plain pywbem.
Diffs
-----
src/software/test/base.py 35e437a65713cfdc5798f928a1e479eec14f3c9a
src/software/test/test_hosted_software_collection.py 6f4adc31cc81e6489029f792bf045e94e226ccf6
src/software/test/test_hosted_software_identity_resource.py df4b11ff096360d8008f0958c7a6233bf58aa28c
src/software/test/test_installed_software_identity.py 31bbd1cdb373f621d9ce53f12b7406cc08ef6f40
src/software/test/test_member_of_software_collection.py 207937c0fbcb58705e572e7c12f9f779cf152f83
src/software/test/test_resource_for_software_identity.py 39bbfb290a33b74d64c8cebf8693ea57f817b688
src/software/test/test_software_identity.py ea60afebe7ad99b30f865b14d3f16cc03944e940
src/software/test/test_software_identity_checks.py e7d364b2d150ca1b220754539cd79113ebaca6af
src/software/test/test_software_identity_file_check.py 96e086d21e4a5e8acbe0aeead4b5d5ffdf155cca
src/software/test/test_software_identity_resource.py d321523173b54bc5db711af738beb5af4c70eaf8
src/software/test/test_system_software_collection.py bf33c562c1241249c570f609dc3a571a22d4af3a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1170/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 6 months
Review Request 1167: providers-tests [1/5] providers: enhanced base test class
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1167/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
providers: enhanced base test class
Added lots of convenience methods. Allowed to use lmi.shell abstractions
if available. openlmi-tools do not need to be installed to use the base
class.
CIMInstanceName and LMIInstanceName are treated the same way
(functions operate upon CIMInstanceName objects and lmi wrappers are
converted to them before the call is done).
Diffs
-----
src/python/lmi/test/base.py eb009144c45f38343ad032361089e13863daa2f2
Diff: http://reviewboard-openlmi.rhcloud.com/r/1167/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 6 months
Review Request 1171: providers-tests [5/5] software: temporarily disabled dangerous tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1171/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: temporarily disabled dangerous tests
Dangerous tests changing yum package database are not reliable because
they operate on dynamically changing repositories. This patch
temporarily disables them until custom testing repositories are created
for the purpose of software tests.
Diffs
-----
src/software/test/base.py 35e437a65713cfdc5798f928a1e479eec14f3c9a
src/software/test/test_installed_software_identity.py 31bbd1cdb373f621d9ce53f12b7406cc08ef6f40
Diff: http://reviewboard-openlmi.rhcloud.com/r/1171/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 6 months
Review Request 1182: tools [1/2] accept shell abstractions besides cim types
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1182/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
accept shell abstractions besides cim types
Allow callers to pass lmi shell wrappers where just cim types were
expected. Both LMIInstance(Name) and CIMInstance(Name) objects represent
the same thing, be benevolent on input and treat them the same way.
Diffs
-----
cli/lmi/shell/LMIMethod.py f17e16946786b8cef6fedca972f4c4a378ee8675
cli/lmi/shell/LMIInstance.py 864e9c2ad7d37d89d85094ac84ad8bac5321e596
cli/lmi/shell/LMIInstanceName.py d88e630b160edbb2fe5799afe60bcefd11903199
cli/lmi/shell/LMIClass.py ae7be66646442c20e3c8583b0b492130dafe6d45
cli/lmi/shell/LMIBaseClient.py 745e487d9ccf619e6428f1b87ec52f615b125f22
Diff: http://reviewboard-openlmi.rhcloud.com/r/1182/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 6 months