----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
indmanager: Get object path from instances to be sent when not polling
When not polling, manager->enums is NULL resulting in segfault. This patch adds extra test and retrieves the object path required from instances to be sent.
Note: this is a wild guess but proved to be working
Diffs -----
src/indmanager/ind_manager.c 7e2cda3c57b63d0e0405ed150ba55cb615b9cedd
Diff: http://reviewboard-openlmi.rhcloud.com/r/717/diff/
Testing -------
Thanks,
Tomáš Bžatek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/#review906 -----------------------------------------------------------
src/indmanager/ind_manager.c http://reviewboard-openlmi.rhcloud.com/r/717/#comment482
Can you please use global im_rc variable? It is intended to store rc of last call. In the future it will be re-used to report errors.
- Roman Rakus
On Aug. 13, 2013, 2:57 p.m., Tomáš Bžatek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/
(Updated Aug. 13, 2013, 2:57 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
indmanager: Get object path from instances to be sent when not polling
When not polling, manager->enums is NULL resulting in segfault. This patch adds extra test and retrieves the object path required from instances to be sent.
Note: this is a wild guess but proved to be working
Diffs
src/indmanager/ind_manager.c 7e2cda3c57b63d0e0405ed150ba55cb615b9cedd
Diff: http://reviewboard-openlmi.rhcloud.com/r/717/diff/
Testing
Thanks,
Tomáš Bžatek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/ -----------------------------------------------------------
(Updated Aug. 15, 2013, 12:42 p.m.)
Review request for OpenLMI Developers.
Changes -------
Posted updated patch, now using global im_rc variable.
Repository: openlmi-providers
Description -------
indmanager: Get object path from instances to be sent when not polling
When not polling, manager->enums is NULL resulting in segfault. This patch adds extra test and retrieves the object path required from instances to be sent.
Note: this is a wild guess but proved to be working
Diffs (updated) -----
src/indmanager/ind_manager.c 4a8c06cd5cc97fef949bdd1f733816ed3452bcd8
Diff: http://reviewboard-openlmi.rhcloud.com/r/717/diff/
Testing -------
Thanks,
Tomáš Bžatek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/#review914 -----------------------------------------------------------
Ship it!
Ship It!
- Roman Rakus
On Aug. 15, 2013, 12:42 p.m., Tomáš Bžatek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/
(Updated Aug. 15, 2013, 12:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
indmanager: Get object path from instances to be sent when not polling
When not polling, manager->enums is NULL resulting in segfault. This patch adds extra test and retrieves the object path required from instances to be sent.
Note: this is a wild guess but proved to be working
Diffs
src/indmanager/ind_manager.c 4a8c06cd5cc97fef949bdd1f733816ed3452bcd8
Diff: http://reviewboard-openlmi.rhcloud.com/r/717/diff/
Testing
Thanks,
Tomáš Bžatek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/717/ -----------------------------------------------------------
(Updated Aug. 15, 2013, 12:53 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
indmanager: Get object path from instances to be sent when not polling
When not polling, manager->enums is NULL resulting in segfault. This patch adds extra test and retrieves the object path required from instances to be sent.
Note: this is a wild guess but proved to be working
Diffs -----
src/indmanager/ind_manager.c 4a8c06cd5cc97fef949bdd1f733816ed3452bcd8
Diff: http://reviewboard-openlmi.rhcloud.com/r/717/diff/
Testing -------
Thanks,
Tomáš Bžatek
openlmi-reviews@lists.fedorahosted.org