----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
spec: modularize spec file
Add support for easier enabling/disabling providers on different versions of hosting operating system.
Also add support for RHEL-6.
Diffs -----
openlmi-providers.spec 9a21e6eab8d60e0ec24c7dbb307453afa16c2069
Diff: http://reviewboard-openlmi.rhcloud.com/r/1663/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/#review2564 -----------------------------------------------------------
Otherwise looks good to me.
openlmi-providers.spec http://reviewboard-openlmi.rhcloud.com/r/1663/#comment1391
Depending on whether the legacy mof is installed with '-legacy' suffix or not (viz previous review), this script and all the following should cope with legacy mof.
- Michal Minar
On May 5, 2014, 8:32 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/
(Updated May 5, 2014, 8:32 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
spec: modularize spec file
Add support for easier enabling/disabling providers on different versions of hosting operating system.
Also add support for RHEL-6.
Diffs
openlmi-providers.spec 9a21e6eab8d60e0ec24c7dbb307453afa16c2069
Diff: http://reviewboard-openlmi.rhcloud.com/r/1663/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/ -----------------------------------------------------------
(Updated May 5, 2014, 1:50 p.m.)
Review request for OpenLMI Developers.
Changes -------
Make the names of mof and reg files the same for both service and service-legacy.
Repository: openlmi-providers
Description -------
spec: modularize spec file
Add support for easier enabling/disabling providers on different versions of hosting operating system.
Also add support for RHEL-6.
Diffs (updated) -----
openlmi-providers.spec 9a21e6eab8d60e0ec24c7dbb307453afa16c2069 src/CMakeLists.txt 79c316cc4c2346a953ecdd269975ec2cb446fbdd
Diff: http://reviewboard-openlmi.rhcloud.com/r/1663/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/#review2594 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On May 5, 2014, 11:50 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/
(Updated May 5, 2014, 11:50 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
spec: modularize spec file
Add support for easier enabling/disabling providers on different versions of hosting operating system.
Also add support for RHEL-6.
Diffs
openlmi-providers.spec 9a21e6eab8d60e0ec24c7dbb307453afa16c2069 src/CMakeLists.txt 79c316cc4c2346a953ecdd269975ec2cb446fbdd
Diff: http://reviewboard-openlmi.rhcloud.com/r/1663/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1663/ -----------------------------------------------------------
(Updated May 9, 2014, 9:32 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
spec: modularize spec file
Add support for easier enabling/disabling providers on different versions of hosting operating system.
Also add support for RHEL-6.
Diffs -----
openlmi-providers.spec 9a21e6eab8d60e0ec24c7dbb307453afa16c2069 src/CMakeLists.txt 79c316cc4c2346a953ecdd269975ec2cb446fbdd
Diff: http://reviewboard-openlmi.rhcloud.com/r/1663/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org