----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2099/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
python-providers: Convert all log messages to string before sending to CIMOM.
Recent blivet update introduced unicode in some of its properties, which ended up in CIMOM log. CIMOM does not like it, it expects const char* and returned weird error message:
CIM_ERR_INVALID_PARAMETER: in method 'CMPIBroker_LogMessage', argument 4 of type 'char const *'
We should convert everything to string before sending to log.
Diffs -----
src/python/lmi/providers/cmpi_logging.py 06dee703c45f4057553048ebeb2b45b3ef5c0909
Diff: http://reviewboard-openlmi.rhcloud.com/r/2099/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2099/#review3464 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Říj. 7, 2014, 11:56 dop., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2099/
(Updated Říj. 7, 2014, 11:56 dop.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
python-providers: Convert all log messages to string before sending to CIMOM.
Recent blivet update introduced unicode in some of its properties, which ended up in CIMOM log. CIMOM does not like it, it expects const char* and returned weird error message:
CIM_ERR_INVALID_PARAMETER: in method 'CMPIBroker_LogMessage', argument 4 of type 'char const *'
We should convert everything to string before sending to log.
Diffs
src/python/lmi/providers/cmpi_logging.py 06dee703c45f4057553048ebeb2b45b3ef5c0909
Diff: http://reviewboard-openlmi.rhcloud.com/r/2099/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2099/ -----------------------------------------------------------
(Updated Říj. 7, 2014, 1:58 odp.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
python-providers: Convert all log messages to string before sending to CIMOM.
Recent blivet update introduced unicode in some of its properties, which ended up in CIMOM log. CIMOM does not like it, it expects const char* and returned weird error message:
CIM_ERR_INVALID_PARAMETER: in method 'CMPIBroker_LogMessage', argument 4 of type 'char const *'
We should convert everything to string before sending to log.
Diffs -----
src/python/lmi/providers/cmpi_logging.py 06dee703c45f4057553048ebeb2b45b3ef5c0909
Diff: http://reviewboard-openlmi.rhcloud.com/r/2099/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org