----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/805/#review1072 -----------------------------------------------------------
src/service-dbus/test/testService.py http://reviewboard-openlmi.rhcloud.com/r/805/#comment596
This asserts only that the sysd_services is a subset of lmi_services. IMHO the opposite case should be checked also: self.assertEqual(set(sysd_services.keys()), set(lmi_services.keys()))
- Michal Minar
On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/805/
(Updated Sept. 2, 2013, 11:16 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Service tests: Upstream test for service profider from QA.
Diffs
src/service-dbus/test/failing.service PRE-CREATION src/service-dbus/test/testService.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
Testing
Thanks,
Robin Hack