On Aug. 23, 2013, 10:32 a.m., Michal Minar wrote:
mof/60_LMI_Journald.mof, line 21 http://reviewboard-openlmi.rhcloud.com/r/690/diff/2/?file=4061#file4061line21
Too old? I guess at least 0.1.0 should be here.
Changed to 0.2.0 for consistency with proposed change in software provider (review #742)
On Aug. 23, 2013, 10:32 a.m., Michal Minar wrote:
mof/60_LMI_Journald.mof, line 59 http://reviewboard-openlmi.rhcloud.com/r/690/diff/2/?file=4061#file4061line59
Having Override("Property") in property's qualifiers renders all the other qualifiers unnecessary if they don't override anything. Aggregate, Key, Min and Max can be omitted here. The same applies to other overriden properties.
Thanks, didn't know that, still learning. Did a cleanup, removed duplicite qualifiers comapring to super class' MOF. Seems to be working fine.
- Tomáš
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/690/#review960 -----------------------------------------------------------
On Aug. 23, 2013, 12:55 p.m., Tomáš Bžatek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/690/
(Updated Aug. 23, 2013, 12:55 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
journald: Basic provider implementation
This is a fully functional basic implementation of the provider.
Maximum number of enumerated instances is limited, see the code.
Diffs
CMakeLists.txt cb3f0a23dabe7f3b05de43a136d510aa6e6206ea mof/60_LMI_Journald.mof PRE-CREATION src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743 src/journald/90_LMI_Journald_Profile.mof.skel PRE-CREATION src/journald/CMakeLists.txt PRE-CREATION src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION src/journald/README PRE-CREATION src/journald/cmpiLMI_Journald-cimprovagt PRE-CREATION src/journald/instutil.h PRE-CREATION src/journald/instutil.c PRE-CREATION src/journald/journal.h PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/690/diff/
Testing
Thanks,
Tomáš Bžatek