On May 6, 2014, 9:16 a.m., Peter Schiffer wrote:
Perhaps you forgot to rebase before submitting the review?
I didn't but whole software-dbus provider needs to be ported to use the new common library, so I didn't want to do it partially in this patch. I'll fix those in following patch.
- Peter
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1667/#review2574 -----------------------------------------------------------
On May 5, 2014, 5:27 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1667/
(Updated May 5, 2014, 5:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider
Diffs
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 9332f62e392103e39a700cedcfaadf72df8e5f53 src/software-dbus/LMI_SoftwareIdentityProvider.c 7e03badf0113ebc981a24d20ccac60131dfb8d74 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c fec2794131a6194510364e45969995729e80108c src/software-dbus/sw-utils.h 16e6ca11e4714ab337c7e554f7c8ced5b06bd37b src/software-dbus/sw-utils.c 76ca58bd0129c3d12695d22da77fb3613c8685b1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1667/diff/
Testing
Thanks,
Peter Schiffer