----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1676/#review2586 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On May 6, 2014, 8:08 p.m., Alois Mahdal wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1676/
(Updated May 6, 2014, 8:08 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
When writing new test, I find myself constantly computing the size from desired strength and prefix length, whereas I mostly don't care about the final size at all (plus, one can usually see that from surrounding code).
Providing strength simplifies use and the function code.
Diffs
src/account/test/TestAccountRaceConditions.py 6125bd3e4cc0830acf7dc5a747a872ec3f17b5c9 src/account/test/common.py 862d1d43f398646302ce2b7cbd25a510cedcea92 src/account/test/methods.py 9c033c5e8494edba2fa7a38046beda577458e09f
Diff: http://reviewboard-openlmi.rhcloud.com/r/1676/diff/
Testing
Thanks,
Alois Mahdal