----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1858/#review2942 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On July 3, 2014, 11:03 a.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1858/
(Updated July 3, 2014, 11:03 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
jobmanager: fix job registration
Any call to jobmgr_register_job_type() needs to be ignored once the job manager is initialized. It's wrong to assume that this function won't ever be called after the jobmgr_init() because there may be several providers doing following sequence in single provider library during its initialization:
- lmi_init()
- jobmgr_register_job_type()
- jobmgr_init()
Diffs
src/libs/jobmanager/job_manager.h 041096a7450f663b84c0cead5d649537aabf5224 src/libs/jobmanager/job_manager.c 2d1f55b6d37490bd69e17a2504e02b9d5d5855bd
Diff: http://reviewboard-openlmi.rhcloud.com/r/1858/diff/
Testing
Thanks,
Michal Minar