[Bug 230831] Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230831
mr.ecik(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
AssignedTo|nobody(a)fedoraproject.org |mr.ecik(a)gmail.com
Flag| |fedora-review?,
| |needinfo?(j.w.r.degoede@hhs.
| |nl)
------- Additional Comments From mr.ecik(a)gmail.com 2007-03-07 12:25 EST -------
REVIEW
** Tarball contains license text so include it into package
** Package should require hicolor-icon-theme or own %{_datadir}/icons/hicolor
** rpmlint louds:
W: games-menus no-documentation
W: games-menus non-conffile-in-etc /etc/xdg/menus/applications-merged/games-
categories.menu
Apart from COPYING, you can also include one of your last fedora-games-list
mails as a README (but only a license is MUST)
We can safely omit the second warning.
And the things I've written about before. Change URL tag, own %{_datadir}/
desktop-directories etc.
Also, if "sources" aren't available anywhere, add a comment that we're an
upstream to clarify things.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 3 months
Re: UltimateStunts packaged but problems with sound
by Hans de Goede
Dan Horák wrote:
> Hello,
>
> I have prepared a package with UltimateStunts - a remake of famous DOS
> game called Stunts
> (http://www.ultimatestunts.nl/index.php?page=0&lang=en). Only the spec
> file is available at http://fedora.danny.cz/ultimatestunts.spec , srpm
> will be uploaded later due some problems with my Internet connection.
> Everything looks good - it is under GPL, it compiles on FC6/x86_64 and
> in mock for Development/i386, tools can be run etc. But the game itself
> has some problem with loading sounds in wav files via the OpenAL/ALUT
> libraries. If there is anybody familiar with these sound libraries,
> please take a look. The errors are here:
>
Hi,
I've been doing some debugging on this and the problem is that playSong (which
gets called when sound is initialised to play the first song), calls setSample
on an SoundObject created from a .ogg, then setSample in turn calls
CSndSample::attachToChannel, which calls alSourcei(x, AL_BUFFER, m_Buffer);
this alSourcei call fails setting alError to "al invalid enum value".
Now later in the game when the sound data gets loaded
alutCreateBufferFromFile() gets called and alutCreateBufferFromFile() is one of
a few alut functions which checks to see if there have been no previous
alError's before it was called and if there were previous error aborts with
the: "There was already an AL error on entry to an ALUT function"
We can work around this problem in 2 ways:
1) call alGetError() after the alSourcei(...) in CSndSample::attachToChannel
2) call alGetError() before alutCreateBufferFromFile(...) in sndsample.cpp
I've choosen to go with method 2, as that will also work around alerror's being
thrown elsewhere (although I've not encountered this situation).
The proper fix would be to fix the code so that alSourcei() does not signal an
error condition, but my understanding of the code is not good enough for that.
It would also be a very good idea to call (and check the result of)
alGetError() after each al call, printing a message if an al call fails, that
would have actually fixed this problem, and at the same made the developers
aware that there is a problem. Error checking is good!
I've attached a patch with wotkaround 2. Please send this mail upstream so that
they can do a proper fix.
Regards,
Hans
16 years, 3 months
[Bug 230831] Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: games-menus - Catagorized submenus for the GNOME/KDE Games menu
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230831
------- Additional Comments From j.w.r.degoede(a)hhs.nl 2007-03-05 14:22 EST -------
(In reply to comment #5)
> (In reply to comment #3)
> > For a lot more info on this. So anyone interested in reviewing this?
> >
>
> I'm interested in reviewing if you fix things I mentioned above. Also I think
> that we can get rid of rpmlint no-documentation warning by including https://
> www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html as a README.
Okay, I usually wait for a complete review (which most of the times turns up
more things to fix) and then fix everything in one go, but if you want a fixed
version first let me know and I'll create a version with the things mentioned
sofar fixed.
(In reply to comment #6)
> Is there a plan to get this integrated into the gnome-menus (redhat-menus?)
> and/or kde-menus(?) packages? In the long term that seems like the right place
> to put these menus.
Well for people who do not install a gazillion games this isn't needed, and I
foresee huge resistance to making this a standard part of xxx-menus . So I'm not
going todo that, but if someone else wants to try I won't stop him :)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
16 years, 3 months