On Thu, Jun 21, 2018 at 11:51 PM, Dusty Mabe dusty@dustymabe.com wrote:
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media
name.
Taken inspiration from releng issue [3] and ansible commit [4]. I am not sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
Yeah , we don't now but added it because we may need in future when F29 is released. I have updated patch (available in attachment) with removing if condition.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
Randy is on PTO currently, will check with lsedlar if he can test this patch on stage.
updates/Fedora-28-updates-20180620.0/compose/AtomicHost/x86_64/images/
[2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-Atomic-28-
20180620.0/compose/AtomicHost/x86_64/images/
[3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/
ansible.git/commit/?id=40c32c97f2dcaab549dba7cbb5fbd1897bd57ed8