On Thu, 2014-06-12 at 10:03 -0400, Stephen Gallagher wrote:
On 06/11/2014 10:16 PM, Simo Sorce wrote:
> On Tue, 2014-06-10 at 10:20 -0400, Stephen Gallagher wrote:
>>
>> I've attached a graphviz document and a rendered PNG of the
>> state diagram to hopefully make it clear. Comments and feedback
>> welcome, but our intent is to be off and implementing before the
>> end of the week.
>
> Btw, I am not sure I understand why a crash would be resolved by a
> deploy, there is quite a difference between an error in deploying
> and a runtime error a while after successfully deployed.
>
That's a case where resetError() is the more likely answer (or a
package update fixing the crash bug). I can add a separate Crashed
state if you really want it, but it seems superfluous to me.
No the thing is that a crash should not generate an error that needs to
be manually reset.
If systemd restarts the process the state should not be an error ...
Simo.
--
Simo Sorce * Red Hat, Inc * New York