Hi, I've started to work on Rawtherapee [1], which was FTB in rawhide since F24. There
are some issues I'd like to discuss how to fix them.
- I've upgraded the source to latest svn from Github. From packaging guidelines, when
using github for downloading a specific commit, the source url should be:
Source0:
https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz#/%{name}-%{sho...
but such a link will download a source named %{name}-%{commit0}.tar.gz (with full commit
in the name instead of shortcommit). Is there an error in guidelines, or am I missing
something?
- There's a bug open [2] because rawtherapee bundles a font and two libraries.
The font is present in the sources, but it's not installed in the system (the file is
not packaged). So, is it ok? I don't understand how the guidelines about bundling
fonts [3] apply here.
About bundling libraries, rawtherapee uses a custom patched version of Klt for building,
plus a heavy patched version of dcraw. Dcraw bundling has been discussed before [4] and
FPC ticket was closed. In the .spec file I can see a "Provides: bundled(dcraw)".
Should I manage Klt bundling like that, with a "Provides" declaration?
Thanks
Mattia
[1]
https://admin.fedoraproject.org/pkgdb/package/rpms/rawtherapee/
[2]
https://bugzilla.redhat.com/show_bug.cgi?id=1248756
[3]
https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fon...
[4]
https://fedorahosted.org/fpc/ticket/530