On Wed, Feb 14, 2007 at 12:04:39AM +0200, Ville Skyttä wrote:
On Tuesday 13 February 2007, you wrote:
>
> The following page has been changed by TomCallaway:
>
http://fedoraproject.org/wiki/Packaging/GuidelinesTodo
[...]
> + ||ratify ||New Required Buildroot||[wiki:Self:TomCallaway
> spot]||2007-02-13||Change required buildroot for new packages to %(mktemp
> -d %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) (old packages/core
> merge packages using old buildroot are grandfathered)||
Using mktemp -d in specfiles' BuildRoot means that quite a few stray temp dirs
will start to appear in %{_tmppath}. For example "rpm -q --specfile
foo.spec" and "rpmbuild -bs foo.spec" create them, and nothing cleans them
up
(no, tmpwatch doesn't count) - we probably don't want that.
One way to avoid it is mktemp -ud, but it's more racy than plain -d. I
think -ud would be a better choice nevertheless.
Good catch! +1
--
Axel.Thimm at
ATrpms.net