update not working correctly